From: Jakub Kicinski <kuba@kernel.org>
To: David Ahern <dsahern@kernel.org>
Cc: Petr Machata <petrm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Ido Schimmel <idosch@nvidia.com>,
Simon Horman <horms@kernel.org>,
mlxsw@nvidia.com
Subject: Re: [PATCH net-next v2 4/7] net: nexthop: Expose nexthop group stats to user space
Date: Fri, 1 Mar 2024 09:28:13 -0800 [thread overview]
Message-ID: <20240301092813.4cb44934@kernel.org> (raw)
In-Reply-To: <148968b2-6d8e-476b-afee-5f1b15713c7e@kernel.org>
On Fri, 1 Mar 2024 08:45:52 -0700 David Ahern wrote:
> > + /* uint; number of packets forwarded via the nexthop group entry */
>
> why not make it a u64?
I think it should be our default type. Explicit length should only
be picked if there's a clear reason. Too many review cycles wasted
steering people onto correct types...
Now, I'm not sure Pablo merged the sint/uint support into libmnl,
I can share the patches to handle them in iproute2, if that helps.
Or just copy/paste from YNL.
I need to find the courage to ask you how we can start using YNL
in iproute2, I really worry that we're not getting CLI tools written
for new families any more :(
next prev parent reply other threads:[~2024-03-01 17:28 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 18:16 [PATCH net-next v2 0/7] Support for nexthop group statistics Petr Machata
2024-02-29 18:16 ` [PATCH net-next v2 1/7] net: nexthop: Adjust netlink policy parsing for a new attribute Petr Machata
2024-03-01 15:31 ` David Ahern
2024-02-29 18:16 ` [PATCH net-next v2 2/7] net: nexthop: Add NHA_OP_FLAGS Petr Machata
2024-03-01 15:36 ` David Ahern
2024-02-29 18:16 ` [PATCH net-next v2 3/7] net: nexthop: Add nexthop group entry stats Petr Machata
2024-03-01 15:36 ` David Ahern
2024-02-29 18:16 ` [PATCH net-next v2 4/7] net: nexthop: Expose nexthop group stats to user space Petr Machata
2024-03-01 15:45 ` David Ahern
2024-03-01 17:17 ` Petr Machata
2024-03-01 17:28 ` Jakub Kicinski [this message]
2024-03-02 2:45 ` David Ahern
2024-03-03 3:36 ` Jakub Kicinski
2024-03-01 17:32 ` Eric Dumazet
2024-03-04 11:09 ` Petr Machata
2024-02-29 18:16 ` [PATCH net-next v2 5/7] net: nexthop: Add hardware statistics notifications Petr Machata
2024-03-01 15:46 ` David Ahern
2024-02-29 18:16 ` [PATCH net-next v2 6/7] net: nexthop: Add ability to enable / disable hardware statistics Petr Machata
2024-03-01 15:49 ` David Ahern
2024-03-01 17:18 ` Petr Machata
2024-02-29 18:16 ` [PATCH net-next v2 7/7] net: nexthop: Expose nexthop group HW stats to user space Petr Machata
2024-03-01 15:55 ` David Ahern
2024-03-01 17:22 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240301092813.4cb44934@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).