From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 478FB17757 for ; Sat, 2 Mar 2024 07:23:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709364215; cv=none; b=uw7zspq/vlj2e3Sbba58LidKQi5rvsRuXsB929142q03hbVzVuDIglGWUax8IsjOXysbO4o0d2b4LUTd0jL0TMgokRgYeQCTfHDGUASwYkYd7aygdt/mukmr0GSthBtEM1Em+xqYKjuuKHRQECvhxRtF/w8DkJPvZ/Xrfaj970s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709364215; c=relaxed/simple; bh=LByt4fDpvLI3yHzi5uT7STPE49xcc8ESEhlPMZSXQHc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DPnhP/v7Swyk81DhvBnXjKe/AdK/Ui301aUWq8TMbXtQC8cevDTwSfjL1JDIvM2JAJ+YM1LpBusm/C+FXxX3K1Mse2sKFBSJQ/ewgUvxX5++Qxdw4xR39hnCP1/qSna2z3pGWRTkSgIM0yazsi/d3tRZrf2Ft+UpPGBO52yYcgE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ScaMrVrz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ScaMrVrz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01970C433C7; Sat, 2 Mar 2024 07:23:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709364215; bh=LByt4fDpvLI3yHzi5uT7STPE49xcc8ESEhlPMZSXQHc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ScaMrVrzksf65CMVjCvOGeBT8JDw1lP6Ix6+UOQ7VacGIR4uKBcEwpYk/+QMuk5xl wa/1u469aSvp4T2ji9UMvYaqwFSYIRQv94vxhR9wCakdQLZBo3jsMIsyobzsuCNfB/ Cqkt8OGrR1UZX862ON9DNLAF7f5ZfrZe0vbczIf80mYe0erQsy9CkjZVuGc5TgHnuh eKMv73PJJx6i6rHL1mx/mBiG8z8Wx3vdgmgzRFbqxOlmePV01BKcmfy/YE6k15Z+4Y pJfsh4OpKMAG9N/fU9UFegsLxMTlN1tcTkLuJnH5zyz5qEFGVbs8rsYPgldda18O6p MTmXKdEBjLRxw== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Gal Pressman , Leon Romanovsky , sridhar.samudrala@intel.com, Jay Vosburgh , Jiri Pirko , Greg Kroah-Hartman Subject: [net-next V4 13/15] net/mlx5e: Block TLS device offload on combined SD netdev Date: Fri, 1 Mar 2024 23:22:43 -0800 Message-ID: <20240302072246.67920-14-saeed@kernel.org> X-Mailer: git-send-email 2.44.0 In-Reply-To: <20240302072246.67920-1-saeed@kernel.org> References: <20240302072246.67920-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Tariq Toukan 1) Each TX TLS device offloaded context has its own TIS object. Extra work is needed to get it working in a SD environment, where a stream can move between different SQs (belonging to different mdevs). 2) Each RX TLS device offloaded context needs a DEK object from the DEK pool. Extra work is needed to get it working in a SD environment, as the DEK pool currently falsely depends on TX cap, and is on the primary device only. Disallow this combination for now. Signed-off-by: Tariq Toukan Reviewed-by: Gal Pressman Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c | 2 +- drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c index 984fa04bd331..e3e57c849436 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.c @@ -96,7 +96,7 @@ bool mlx5e_is_ktls_rx(struct mlx5_core_dev *mdev) { u8 max_sq_wqebbs = mlx5e_get_max_sq_wqebbs(mdev); - if (is_kdump_kernel() || !MLX5_CAP_GEN(mdev, tls_rx)) + if (is_kdump_kernel() || !MLX5_CAP_GEN(mdev, tls_rx) || mlx5_get_sd(mdev)) return false; /* Check the possibility to post the required ICOSQ WQEs. */ diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h index f11075e67658..adc6d8ea0960 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ktls.h @@ -11,6 +11,7 @@ #ifdef CONFIG_MLX5_EN_TLS #include "lib/crypto.h" +#include "lib/mlx5.h" struct mlx5_crypto_dek *mlx5_ktls_create_key(struct mlx5_crypto_dek_pool *dek_pool, struct tls_crypto_info *crypto_info); @@ -61,7 +62,8 @@ void mlx5e_ktls_rx_resync_destroy_resp_list(struct mlx5e_ktls_resync_resp *resp_ static inline bool mlx5e_is_ktls_tx(struct mlx5_core_dev *mdev) { - return !is_kdump_kernel() && MLX5_CAP_GEN(mdev, tls_tx); + return !is_kdump_kernel() && MLX5_CAP_GEN(mdev, tls_tx) && + !mlx5_get_sd(mdev); } bool mlx5e_is_ktls_rx(struct mlx5_core_dev *mdev); -- 2.44.0