From: Jakub Kicinski <kuba@kernel.org>
To: Horatiu Vultur - M31836 <Horatiu.Vultur@microchip.com>
Cc: Arun Ramadoss - I17769 <Arun.Ramadoss@microchip.com>,
"andrew@lunn.ch" <andrew@lunn.ch>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"wojciech.drewek@intel.com" <wojciech.drewek@intel.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
UNGLinuxDriver <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net-next v2 2/2] net: phy: micrel: lan8814 cable improvement errata
Date: Sat, 2 Mar 2024 19:40:41 -0800 [thread overview]
Message-ID: <20240302194041.5d8f8fad@kernel.org> (raw)
In-Reply-To: <20240301072757.t36qqf47erk4jygr@DEN-DL-M31836.microchip.com>
On Fri, 1 Mar 2024 08:27:57 +0100 Horatiu Vultur - M31836 wrote:
> > > +#define LAN8814_PD_CONTROLS 0x9d
> > > +#define LAN8814_PD_CONTROLS_PD_MEAS_TIME_MASK_ GENMASK(3, 0)
> > > +#define LAN8814_PD_CONTROLS_PD_MEAS_TIME_VAL_ 0xb
> >
> > nitpick: TIME_VAL macro is very generic if it can end with specific
> > like TIME_VAL_100M or something similar will gives more readability.
>
> Actually I prefer to keep it like this the name if it is possible..
> Because the VAL_ represents the value and MASK_ represents the mask
> value. Therefore the actual bits name of the register is
> LAN8814_PD_CONTROLS_PD_MEAS_TIME.
>
> I am trying to have a naming convetion about how to define names in this
> file:
> <TARGET>_<REG_NAME>_<REG_BITS_NAME>
Why the trailing underscores, tho?
next prev parent reply other threads:[~2024-03-03 3:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-29 19:52 [PATCH net-next v2 0/2] net: phy: micrel: lan8814 erratas Horatiu Vultur
2024-02-29 19:52 ` [PATCH net-next v2 1/2] net: phy: micrel: lan8814 led errata Horatiu Vultur
2024-03-01 8:17 ` Wojciech Drewek
2024-02-29 19:52 ` [PATCH net-next v2 2/2] net: phy: micrel: lan8814 cable improvement errata Horatiu Vultur
2024-03-01 3:27 ` Arun.Ramadoss
2024-03-01 7:27 ` Horatiu Vultur - M31836
2024-03-03 3:40 ` Jakub Kicinski [this message]
2024-03-04 8:48 ` Horatiu Vultur - M31836
2024-03-01 8:18 ` Wojciech Drewek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240302194041.5d8f8fad@kernel.org \
--to=kuba@kernel.org \
--cc=Arun.Ramadoss@microchip.com \
--cc=Horatiu.Vultur@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wojciech.drewek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).