* [PATCH] Removed blocking_link field description to prevent kernel doc warning
@ 2024-03-03 14:43 R SUNDAR
2024-03-04 17:28 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: R SUNDAR @ 2024-03-03 14:43 UTC (permalink / raw)
To: jmaloy, ying.xue, davem, edumazet, kuba, pabeni
Cc: netdev, tipc-discussion, linux-kernel, R SUNDAR
./net/tipc/socket.c:143: warning: Excess struct member 'blocking_link' description in 'tipc_sock'
Signed-off-by: R SUNDAR <prosunofficial@gmail.com>
---
net/tipc/socket.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/tipc/socket.c b/net/tipc/socket.c
index bb1118d02f95..7e4135db5816 100644
--- a/net/tipc/socket.c
+++ b/net/tipc/socket.c
@@ -80,7 +80,6 @@ struct sockaddr_pair {
* @phdr: preformatted message header used when sending messages
* @cong_links: list of congested links
* @publications: list of publications for port
- * @blocking_link: address of the congested link we are currently sleeping on
* @pub_count: total # of publications port has made during its lifetime
* @conn_timeout: the time we can wait for an unresponded setup request
* @probe_unacked: probe has not received ack yet
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Removed blocking_link field description to prevent kernel doc warning
2024-03-03 14:43 [PATCH] Removed blocking_link field description to prevent kernel doc warning R SUNDAR
@ 2024-03-04 17:28 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2024-03-04 17:28 UTC (permalink / raw)
To: R SUNDAR
Cc: jmaloy, ying.xue, davem, edumazet, kuba, pabeni, netdev,
tipc-discussion, linux-kernel
On Sun, Mar 03, 2024 at 08:13:59PM +0530, R SUNDAR wrote:
> ./net/tipc/socket.c:143: warning: Excess struct member 'blocking_link' description in 'tipc_sock'
>
> Signed-off-by: R SUNDAR <prosunofficial@gmail.com>
> ---
> net/tipc/socket.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/net/tipc/socket.c b/net/tipc/socket.c
> index bb1118d02f95..7e4135db5816 100644
> --- a/net/tipc/socket.c
> +++ b/net/tipc/socket.c
> @@ -80,7 +80,6 @@ struct sockaddr_pair {
> * @phdr: preformatted message header used when sending messages
> * @cong_links: list of congested links
> * @publications: list of publications for port
> - * @blocking_link: address of the congested link we are currently sleeping on
> * @pub_count: total # of publications port has made during its lifetime
> * @conn_timeout: the time we can wait for an unresponded setup request
> * @probe_unacked: probe has not received ack yet
Thanks, this looks good.
However, it duplicates a patch accepted upstream in January.
Link: https://git.kernel.org/netdev/net-next/c/88bf1b8f3c31
--
pw-bot: not-applicable
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-04 17:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-03 14:43 [PATCH] Removed blocking_link field description to prevent kernel doc warning R SUNDAR
2024-03-04 17:28 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).