From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 91877405F2 for ; Tue, 5 Mar 2024 04:42:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709613771; cv=none; b=nE9z/onLqcnzHGumVRP5FeL4K9rDc8FwRLqfDgandjjykPNQr0oexbxZhtWfU9veAgsRUQRonuV8O0QPnwni9SGHsGvWWkAxImO3KxqUTKOxGQKOVbgnrR0c0CLUD9HfxOcxllG7ZEx/X7sCVzgEHCV5LhporvmNY5faQadeZoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709613771; c=relaxed/simple; bh=kInWDpNJYdfASvcKKWYy8LXQBr7YKwbhHEgqjG3jnvc=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=RRZWGu6NfNcQFkPJuYU539bH43JyZMLiNiwKmdt6tqR84ORsbcmW1JYdT3HBMeIwRM1QnEu5fihzHPEd9LkCCRk06nQ2HLJaQ+vtEiXqygEL8iXgVb/AegiLNMroGNH1QjERaqEI1cdEJkW299fO4eXlRT/zzbIMmXQs3Zdd+LI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IcoV2b2n; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IcoV2b2n" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E663AC43390; Tue, 5 Mar 2024 04:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709613771; bh=kInWDpNJYdfASvcKKWYy8LXQBr7YKwbhHEgqjG3jnvc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IcoV2b2nEN4QhqoRRAID8/+yd3rUkvgGP8CxOfQQPGNNev9d4pBmWfMI0G9Z4h01k 6M2dZDCrr7O4a0TpXEwpZiu8Tj8kJ4F+Zsj52wqitZauGfucGy8NLUWGH8xo0H14r9 0BaCpgzmloyyutdankAhLnGj8tO53kF/LHIkYlAZ6UMTFiYxM6c5QNFn0ZpzmmxPAY 5SIEdEOiQDnKjMCd2D60zedVG8AplsNm7kABlOu+aIGKkTJ5rQ4w2CXpifeLJCg8Ee pVAUE3knS0gN9u/iF4Ns4nZGWIPqJmZZ0ubt0ivfB9e8Hk/Icmsuwza6ZY51yXCS9R PmMmXZQEheu8Q== Date: Mon, 4 Mar 2024 20:42:49 -0800 From: Jakub Kicinski To: Geoff Levand Cc: "David S. Miller" , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next v1] ps3_gelic_net: Use napi routines for RX SKB Message-ID: <20240304204249.64fc470f@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 1 Mar 2024 17:20:11 +0900 Geoff Levand wrote: > + descr->skb = napi_build_skb(napi_buff, napi_buff_size); > + > + if (unlikely(!descr->skb)) { > + skb_free_frag(napi_buff); > return -ENOMEM; > } > > - offset = ((unsigned long)descr->skb->data) & > - (GELIC_NET_RXBUF_ALIGN - 1); > - if (offset) > - skb_reserve(descr->skb, GELIC_NET_RXBUF_ALIGN - offset); > - /* io-mmu-map the skb */ > - cpu_addr = dma_map_single(ctodev(card), descr->skb->data, > - GELIC_NET_MAX_FRAME, DMA_FROM_DEVICE); > - descr->hw_regs.payload.dev_addr = cpu_to_be32(cpu_addr); > - if (dma_mapping_error(ctodev(card), cpu_addr)) { > - dev_kfree_skb_any(descr->skb); > + cpu_addr = dma_map_single(dev, napi_buff, napi_buff_size, > + DMA_FROM_DEVICE); > + > + if (dma_mapping_error(dev, cpu_addr)) { > + skb_free_frag(napi_buff); After you called napi_build_skb() you should be operating (here: freeing) the skb not the underlying buffer. -- pw-bot: cr