From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D7504C637; Tue, 5 Mar 2024 07:18:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.200 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709623085; cv=none; b=t07Qrl8MIxfCZBy2e2u34v74of2gG3KitRIRr/q/nN2GYoh97SobYwa4QnStit2zdqUrBdcLdoTLGShbeNjJgtPzRCxpKYw5c2h70jBQCIGvpOwkxg5jg48UGgMdipPvtrVxdjm+g7/QcDRuMVioo9kwZusz+lI66TtE9M1kd5w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709623085; c=relaxed/simple; bh=Ixi/76JR1Pv31+3D5ECr3XuT5VyFkR/xNTnNK8sh2Rk=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EWLs3gqwj9uzOpWu4PDisvnFtXazalubuiqRJC2e8HXUo98MCHW1VCU8WGHvCnD+GmMR+Z24Q/R6o63dYg3sQioFsQ1KfbqJ/SaECpSLHICB63g81P73xjEp8RB18uDfYqfWe96IyTs3kMQoX8IN1fXl8V1XmT+ikQYRGwWeQMM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=phRzA5j0; arc=none smtp.client-ip=217.70.183.200 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="phRzA5j0" Received: by mail.gandi.net (Postfix) with ESMTPSA id 9793B20002; Tue, 5 Mar 2024 07:17:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709623080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nh+UsJveD1Ecym5lcFf+LilE3aXKcM7NsG4y2GIHCgw=; b=phRzA5j0/oSjNsnnn0j/EbWetXZsK1SKRUc5jRbru3IRKlGhfw/Ixl5MOzKc38yngt0T9W lx9u3Fxk00/uHGcHc1HP8L4S3XGv2xWOYXD/M1HifH3Em+K+O978NmmjNVVLp8IiLTwpwQ BwgwAWWx+QNYA7gj7simF+3mWgwXDQg2y7QI72fKLz6raikY6hk0NZsEaWEbDJqwFGz5JI HCpaCsP2fQnm2KZM2dfWDAbYzLNvyRo26T+e2x0RccDk7sao8vctkDf+kFa/UDPhdq0iKU oo0dnEW948LYRfd+vZup5EPOvwS9fgva5ZPN6/aOGaVqjV2I1qisqR1N6WZ9ZA== Date: Tue, 5 Mar 2024 08:17:57 +0100 From: Herve Codina To: Simon Horman Cc: "Ricardo B. Marliere" , Yisen Zhuang , Salil Mehta , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Loic Poulain , Sergey Ryazanov , Johannes Berg , Krzysztof Kozlowski , Greg Kroah-Hartman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ppp@vger.kernel.org Subject: Re: [PATCH net-next 2/6] net: wan: framer: make framer_class constant Message-ID: <20240305081757.00474e37@bootlin.com> In-Reply-To: <20240304175246.GO403078@kernel.org> References: <20240302-class_cleanup-net-next-v1-0-8fa378595b93@marliere.net> <20240302-class_cleanup-net-next-v1-2-8fa378595b93@marliere.net> <20240304175246.GO403078@kernel.org> Organization: Bootlin X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Sasl: herve.codina@bootlin.com Hi, On Mon, 4 Mar 2024 17:52:46 +0000 Simon Horman wrote: > + Herve Codina > > On Sat, Mar 02, 2024 at 02:05:58PM -0300, Ricardo B. Marliere wrote: > > Since commit 43a7206b0963 ("driver core: class: make class_register() take > > a const *"), the driver core allows for struct class to be in read-only > > memory, so move the framer_class structure to be declared at build time > > placing it into read-only memory, instead of having to be dynamically > > allocated at boot time. > > > > Cc: Greg Kroah-Hartman > > Suggested-by: Greg Kroah-Hartman > > Signed-off-by: Ricardo B. Marliere > > Reviewed-by: Simon Horman > Thanks for the patch. Acked-by: Herve Codina Best regards, Hervé