From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ADA1B5490B; Tue, 5 Mar 2024 10:10:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709633437; cv=none; b=CQcfRCIsRRHbUW+5LE86GqfcbEeIPpxvE/ojkUGsuGt8AYLv/4izsGiORMCDOlHhsrcu1ZaqMfihQJaZmSR+2bM626rGpackSBGK4AngUyGkJbVA6Gn6EM4YcL7wPMX87ZeOk1f/ce1Za6EyhFBPThUapeKy7BW6EyiwfsVt9gk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709633437; c=relaxed/simple; bh=OAVORbio8rX6MP7JstBR8elPmW+TfA86LMRUm++6e/M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CwS1iRCbSRBF3Oo0KI3Kac00qjP+7TocyRj+PHhADgxNuIl3OEL0p02g58McVfnl4i+ZrIkOBs3umN/06df9322EzYQP1LrOt7vfMKtM/U+7b4RfGBqcj89AV2BUGl1o2rtFMetOHAA2jxg8WEHZabV1zLHB7FwRQBhSrinNWww= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=Hb5413ee; arc=none smtp.client-ip=217.70.183.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="Hb5413ee" Received: by mail.gandi.net (Postfix) with ESMTPSA id 956D76000A; Tue, 5 Mar 2024 10:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1709633426; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OAVORbio8rX6MP7JstBR8elPmW+TfA86LMRUm++6e/M=; b=Hb5413eedQK0YxQ1ILt65ybaUrNRAGNuplmwg//4ZQJjbbmG62g1t5GGVso/Et3lv2+wX4 8T8hKdXBDXCYIW/ac983hQYxrucOUJ8QMkLOGBBVAjHIhBhdkqxvOcQ38UCp2/xXZUnYwz lgGee57RS1o0nFDWciYaCRsouSfckHadobj1iJOwElo6GhuMaQiSM9g8cpu84xSUT0ddm0 AnqLohvyJG4BeZkLMwXhTIVdcGM7l9sPzImFcCR1gv/W8i+qVguhLVBj6qqkzmuudSZo6M 1tD3t8hDMcZHuNuorgTOmH0R4WEB0MaHkhjY77/jxm3N1emWCFo7rHa1yoD6zg== Date: Tue, 5 Mar 2024 11:10:21 +0100 From: =?UTF-8?B?S8O2cnk=?= Maincent To: "Russell King (Oracle)" Cc: Jakub Kicinski , Florian Fainelli , Broadcom internal kernel review list , Andrew Lunn , Heiner Kallweit , "David S. Miller" , Eric Dumazet , Paolo Abeni , Richard Cochran , Radu Pirea , Jay Vosburgh , Andy Gospodarek , Nicolas Ferre , Claudiu Beznea , Willem de Bruijn , Jonathan Corbet , Horatiu Vultur , UNGLinuxDriver@microchip.com, Simon Horman , Vladimir Oltean , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier , Rahul Rameshbabu Subject: Re: [PATCH net-next v9 08/13] ptp: Add phc source and helpers to register specific PTP clock or get information Message-ID: <20240305111021.5c892d5a@kmaincent-XPS-13-7390> In-Reply-To: References: <20240226-feature_ptp_netnext-v9-0-455611549f21@bootlin.com> <20240226-feature_ptp_netnext-v9-8-455611549f21@bootlin.com> <20240304185734.5f1a476c@kernel.org> Organization: bootlin X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: kory.maincent@bootlin.com On Tue, 5 Mar 2024 08:36:54 +0000 "Russell King (Oracle)" wrote: > On Mon, Mar 04, 2024 at 06:57:34PM -0800, Jakub Kicinski wrote: > > On Mon, 26 Feb 2024 14:39:59 +0100 Kory Maincent wrote: =20 > > > Prepare for future hardware timestamp selection by adding source and > > > corresponding pointers to ptp_clock structure. Additionally, introduce > > > helpers for registering specific phydev or netdev PTP clocks, retriev= ing > > > PTP clock information such as hwtstamp source or phydev/netdev pointe= rs, > > > and obtaining the ptp_clock structure from the phc index. =20 > >=20 > > Can we assume there's one PHC per netdev? > > We both store the netdev/phydev info in the ptp clock > > and ptp clock in the netdev. Is there a reason for that? =20 >=20 > No. In the case of mvpp2 + marvell PHY, the two PTP implementations are > entirely separate. Yes the PTP clock can be independent from the netdev. We need to know which software layer register the PHC to be able to call its callbacks. My commit log is a bit small here. I will enhance it in the next version. Regards, --=20 K=C3=B6ry Maincent, Bootlin Embedded Linux and kernel engineering https://bootlin.com