From: Jakub Kicinski <kuba@kernel.org>
To: Dragos Tatulea <dtatulea@nvidia.com>
Cc: Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
"David Ahern" <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, <leonro@nvidia.com>,
<gal@nvidia.com>,
"Anatoli N . Chechelnickiy"
<Anatoli.Chechelnickiy@m.interpipe.biz>,
Ian Kumlien <ian.kumlien@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Mina Almasry <almasrymina@google.com>
Subject: Re: [RFC] net: esp: fix bad handling of pages from page_pool
Date: Tue, 5 Mar 2024 19:04:27 -0800 [thread overview]
Message-ID: <20240305190427.757b92b8@kernel.org> (raw)
In-Reply-To: <20240304094950.761233-1-dtatulea@nvidia.com>
On Mon, 4 Mar 2024 11:48:52 +0200 Dragos Tatulea wrote:
> When the skb is reorganized during esp_output (!esp->inline), the pages
> coming from the original skb fragments are supposed to be released back
> to the system through put_page. But if the skb fragment pages are
> originating from a page_pool, calling put_page on them will trigger a
> page_pool leak which will eventually result in a crash.
So it just does: skb_shinfo(skb)->nr_frags = 1;
and assumes that's equivalent to owning a page ref on all the frags?
Fix looks more or less good, we would need a new wrapper to avoid
build issues without PAGE_POOL, but I wonder if we wouldn't be better
off changing the other side. Instead of "cutting off" the frags -
walking them and dealing with various page types. Because Mina and co.
will step onto this landmine as well.
next prev parent reply other threads:[~2024-03-06 3:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 9:48 [RFC] net: esp: fix bad handling of pages from page_pool Dragos Tatulea
2024-03-06 3:04 ` Jakub Kicinski [this message]
2024-03-06 13:05 ` Dragos Tatulea
2024-03-06 15:22 ` Jakub Kicinski
2024-03-06 16:00 ` Dragos Tatulea
2024-03-06 16:09 ` Jakub Kicinski
2024-03-06 16:40 ` Mina Almasry
2024-03-06 17:09 ` Dragos Tatulea
2024-03-06 17:27 ` Mina Almasry
2024-03-06 17:41 ` Jakub Kicinski
2024-03-06 18:41 ` Mina Almasry
2024-03-06 18:46 ` Mina Almasry
2024-03-07 2:16 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240305190427.757b92b8@kernel.org \
--to=kuba@kernel.org \
--cc=Anatoli.Chechelnickiy@m.interpipe.biz \
--cc=almasrymina@google.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=dtatulea@nvidia.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=herbert@gondor.apana.org.au \
--cc=ian.kumlien@gmail.com \
--cc=leonro@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).