netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
	Gal Pressman <gal@nvidia.com>,
	Leon Romanovsky <leonro@nvidia.com>
Subject: [net-next V5 06/15] net/mlx5: SD, Add informative prints in kernel log
Date: Tue,  5 Mar 2024 19:02:49 -0800	[thread overview]
Message-ID: <20240306030258.16874-7-saeed@kernel.org> (raw)
In-Reply-To: <20240306030258.16874-1-saeed@kernel.org>

From: Tariq Toukan <tariqt@nvidia.com>

Print to kernel log when an SD group moves from/to ready state.

Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 .../net/ethernet/mellanox/mlx5/core/lib/sd.c  | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c b/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c
index 76c2426c2498..918138c13a92 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/lib/sd.c
@@ -376,6 +376,21 @@ static void sd_cmd_unset_secondary(struct mlx5_core_dev *secondary)
 	mlx5_fs_cmd_set_l2table_entry_silent(secondary, 0);
 }
 
+static void sd_print_group(struct mlx5_core_dev *primary)
+{
+	struct mlx5_sd *sd = mlx5_get_sd(primary);
+	struct mlx5_core_dev *pos;
+	int i;
+
+	sd_info(primary, "group id %#x, primary %s, vhca %#x\n",
+		sd->group_id, pci_name(primary->pdev),
+		MLX5_CAP_GEN(primary, vhca_id));
+	mlx5_sd_for_each_secondary(i, primary, pos)
+		sd_info(primary, "group id %#x, secondary_%d %s, vhca %#x\n",
+			sd->group_id, i - 1, pci_name(pos->pdev),
+			MLX5_CAP_GEN(pos, vhca_id));
+}
+
 int mlx5_sd_init(struct mlx5_core_dev *dev)
 {
 	struct mlx5_core_dev *primary, *pos, *to;
@@ -413,6 +428,10 @@ int mlx5_sd_init(struct mlx5_core_dev *dev)
 			goto err_unset_secondaries;
 	}
 
+	sd_info(primary, "group id %#x, size %d, combined\n",
+		sd->group_id, mlx5_devcom_comp_get_size(sd->devcom));
+	sd_print_group(primary);
+
 	return 0;
 
 err_unset_secondaries:
@@ -443,6 +462,8 @@ void mlx5_sd_cleanup(struct mlx5_core_dev *dev)
 	mlx5_sd_for_each_secondary(i, primary, pos)
 		sd_cmd_unset_secondary(pos);
 	sd_cmd_unset_primary(primary);
+
+	sd_info(primary, "group id %#x, uncombined\n", sd->group_id);
 out:
 	sd_unregister(dev);
 	sd_cleanup(dev);
-- 
2.44.0


  parent reply	other threads:[~2024-03-06  3:03 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06  3:02 [pull request][net-next V5 00/15] mlx5 socket direct (Multi-PF) Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 01/15] net/mlx5: Add MPIR bit in mcam_access_reg Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 02/15] net/mlx5: SD, Introduce SD lib Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 03/15] net/mlx5: SD, Implement basic query and instantiation Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 04/15] net/mlx5: SD, Implement devcom communication and primary election Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 05/15] net/mlx5: SD, Implement steering for primary and secondaries Saeed Mahameed
2024-03-06  3:02 ` Saeed Mahameed [this message]
2024-03-06  3:02 ` [net-next V5 07/15] net/mlx5: SD, Add debugfs Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 08/15] net/mlx5e: Create single netdev per SD group Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 09/15] net/mlx5e: Create EN core HW resources for all secondary devices Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 10/15] net/mlx5e: Let channels be SD-aware Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 11/15] net/mlx5e: Support cross-vhca RSS Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 12/15] net/mlx5e: Support per-mdev queue counter Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 13/15] net/mlx5e: Block TLS device offload on combined SD netdev Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 14/15] net/mlx5: Enable SD feature Saeed Mahameed
2024-03-06  3:02 ` [net-next V5 15/15] Documentation: networking: Add description for multi-pf netdev Saeed Mahameed
2024-03-07  4:53   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240306030258.16874-7-saeed@kernel.org \
    --to=saeed@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gal@nvidia.com \
    --cc=kuba@kernel.org \
    --cc=leonro@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).