From: Jakub Kicinski <kuba@kernel.org>
To: Herve Codina <herve.codina@bootlin.com>
Cc: Ratheesh Kannoth <rkannoth@marvell.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH v6 1/5] net: wan: Add support for QMC HDLC
Date: Wed, 6 Mar 2024 09:52:05 -0800 [thread overview]
Message-ID: <20240306095205.5875d8ae@kernel.org> (raw)
In-Reply-To: <20240306184611.0cea20af@bootlin.com>
On Wed, 6 Mar 2024 18:46:11 +0100 Herve Codina wrote:
> > > ACK. Usually I get comments to split declaration and assignment for
> > > my patches in upstream.
> >
> > Yup, that's our general preference, to split the init out of
> > the definition.
>
> Does it mean that I need to update in a next iteration ?
If you'd be so kind.
next prev parent reply other threads:[~2024-03-06 17:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 8:07 [PATCH v6 0/5] Add support for QMC HDLC Herve Codina
2024-03-06 8:07 ` [PATCH v6 1/5] net: wan: " Herve Codina
2024-03-06 10:56 ` Ratheesh Kannoth
2024-03-06 13:37 ` Herve Codina
2024-03-06 16:01 ` [EXTERNAL] " Ratheesh Kannoth
2024-03-06 16:22 ` Jakub Kicinski
2024-03-06 17:46 ` Herve Codina
2024-03-06 17:52 ` Jakub Kicinski [this message]
2024-03-06 13:27 ` Yury Norov
2024-03-06 13:38 ` Andy Shevchenko
2024-03-06 16:22 ` Jakub Kicinski
2024-03-06 8:07 ` [PATCH v6 2/5] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2024-03-06 8:07 ` [PATCH v6 3/5] lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers Herve Codina
2024-03-06 13:11 ` Yury Norov
2024-03-06 13:39 ` Andy Shevchenko
2024-03-07 7:31 ` Herve Codina
2024-03-06 8:07 ` [PATCH v6 4/5] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support Herve Codina
2024-03-06 13:06 ` Yury Norov
2024-03-06 13:43 ` Andy Shevchenko
2024-03-06 15:43 ` Herve Codina
2024-03-06 15:55 ` Andy Shevchenko
2024-03-07 7:26 ` Herve Codina
2024-03-06 8:07 ` [PATCH v6 5/5] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240306095205.5875d8ae@kernel.org \
--to=kuba@kernel.org \
--cc=herve.codina@bootlin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rkannoth@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).