From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5C4FA14198E for ; Wed, 6 Mar 2024 18:03:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709748215; cv=none; b=NE7c4UmYMNzK+HNEeDApGezLpzcEunBs6nZdJDdAn3lUIqq1b74/59cKXiv3c6CCKum961ranoG7H6nrJ6fdsYwPNw/Do9KEuMCfL6K60hMFccDnpmguNzLXjhJg7+UeC9yo9X+GaN26vLw/uibmnsL0QJkZXSDbXbLowOvqD28= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709748215; c=relaxed/simple; bh=PHJUVwqfiNgw5vNIMKxIICyg1+WyBLjZ2Dq3h66vRdA=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=jZx7f/VedTNq3Oc2EDvNqeew8sShpG6x9bZBaFzCAHaqcbfpXwx0bZSdQQpsBb884H8p72Cu3577IBeFdUdo5iy4CiviDZ4D9unllHY3oQf8p92kLL+jAQrpWZrFVa0p+7ga1fpPgzSdb85gpba2o96yZpk5PAFNejyQNmC5k60= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=levKoCIE; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="levKoCIE" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F74FC433C7; Wed, 6 Mar 2024 18:03:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709748214; bh=PHJUVwqfiNgw5vNIMKxIICyg1+WyBLjZ2Dq3h66vRdA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=levKoCIEBYD1YDSAIQ1VncM3YwSQkjuwKvSCZzxqM6gHLNwGHvUQHDXlRvz47RKJM 1PS6dXKtgZvvXGgSTxZFGjuwKy1VhpRpm0SpHrF3DG/29zJgliX0L5RHtYGnGHsx0/ UcxqeEhOLZUq3EBryca88unusJKGw7og0DWAZwht9Mn3sRcHr67j4vs0xW1bDNR/yf ZFJNN6BRqTl6EXCop2Y7n83knyHna5a46cQTL7tG6hzXn0LNJHwzXr2vCMR4xrOoJY YFaT0ueLCvhE55NoAh/15AaZ6QQ87wpzWl7YCzvmJpCXa2lJgc1XriBG7/doUi5sFZ 31QSHwz9v2aOA== Date: Wed, 6 Mar 2024 10:03:33 -0800 From: Jakub Kicinski To: Donald Hunter Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Jacob Keller , Jiri Pirko , Stanislav Fomichev , donald.hunter@redhat.com Subject: Re: [PATCH net-next v2 3/5] tools/net/ynl: Fix c codegen for array-nest Message-ID: <20240306100333.502fa911@kernel.org> In-Reply-To: <20240306125704.63934-4-donald.hunter@gmail.com> References: <20240306125704.63934-1-donald.hunter@gmail.com> <20240306125704.63934-4-donald.hunter@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 6 Mar 2024 12:57:02 +0000 Donald Hunter wrote: > ynl-gen-c generates e.g. 'calloc(mcast_groups, sizeof(*dst->mcast_groups))' > for array-nest attrs when it should be 'n_mcast_groups'. > > Add a 'n_' prefix in the generated code for array-nests. Reviewed-by: Jakub Kicinski