From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58A00140368; Wed, 6 Mar 2024 19:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709754232; cv=none; b=uToBwZCrVfyGEpZuZeYihzZudYgRo7mxAEAfFWolCybtduAxbJNtvvF6CioXpJKT6naCnCnFDdA2+q/3RNW5pTh3ic2kMg1F5/znRjONSZvnZai4v0vLDvK4nxt9M2gWf4MfNE/af0OicK/7J8cqyoEYpyWmltKh6bLTnk62qO8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709754232; c=relaxed/simple; bh=cDcynlg09PGkT09NRyUpJm9Vb1/jsYZ/mjlNe+XyGRQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Z5lcCV5Ble7oB/UrhEcCpZtGCunCS2Z0slo0dIL3FcjoCy5Rbrjegefe3Xmk3Vo+y/mXj6fGLiOFiUgiEVdONUuvXEJuR8+ei9fx/iYmo5CamS3wzdXZTGfr9D3ML2VvH7Hp21G6P1LunyXUFF3mOuXunsulCgfU7NrNO3D0vfo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VVuqLScG; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VVuqLScG" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 421BAC433F1; Wed, 6 Mar 2024 19:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709754231; bh=cDcynlg09PGkT09NRyUpJm9Vb1/jsYZ/mjlNe+XyGRQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VVuqLScGrbDQLbjTW+Gko6kM1DNY9/oIAe6jT28G1JpZflHZGIelb5Ibrv6VA1lKx VV3EEJrKuzmmln98Q8oujcR3jh5pFqjgR0GUrlfg3VuhaTSwYQ/QRMPJXI4ATGZcvW sDYu8ASnyK5GN10BhEu7rghIP6FeZeJaZsB0me8EjAw/ylNclzFE44FV172bNvnOTh XMYuebMh+yAHKZG3+HKPYuKgDzRqFJTYQyZbqF278Y1S/W/RMuZ8a1jQmucnYIcMmX Gsf7nCTXC0mhCbWxFB/U3cZbXV/QiPJDPGrSy5Abz8oocTsaSylSFre0/sz1AIDPkl oQbylq66sqmFA== Date: Wed, 6 Mar 2024 19:43:47 +0000 From: Simon Horman To: Breno Leitao Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dsahern@kernel.org Subject: Re: [PATCH net-next 2/2] net: geneve: Remove generic .ndo_get_stats64 Message-ID: <20240306194347.GB281974@kernel.org> References: <20240305172911.502058-1-leitao@debian.org> <20240305172911.502058-2-leitao@debian.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305172911.502058-2-leitao@debian.org> On Tue, Mar 05, 2024 at 09:29:10AM -0800, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman