netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yang Xiwen via B4 Relay <devnull+forbidden405.outlook.com@kernel.org>
To: Yisen Zhuang <yisen.zhuang@huawei.com>,
	 Salil Mehta <salil.mehta@huawei.com>,
	 "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	 Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
	 Heiner Kallweit <hkallweit1@gmail.com>,
	 Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	 devicetree@vger.kernel.org,
	Yang Xiwen <forbidden405@outlook.com>,
	 Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [PATCH net-next v9 5/9] dt-bindings: net: hisi-femac: add mandatory MDIO bus subnode
Date: Thu, 07 Mar 2024 19:34:51 +0800	[thread overview]
Message-ID: <20240307-net-v9-5-6e0cf3e6584d@outlook.com> (raw)
In-Reply-To: <20240307-net-v9-0-6e0cf3e6584d@outlook.com>

From: Yang Xiwen <forbidden405@outlook.com>

FEMAC core always has an integrated MDIO bus mapped in its address
space. Add required properties '#address-cells', 'size-cells', 'ranges'
and MDIO bus subnode.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
---
 .../bindings/net/hisilicon,hisi-femac.yaml         | 30 ++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
index 3344d3bfefb8..5cd2331668bc 100644
--- a/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
+++ b/Documentation/devicetree/bindings/net/hisilicon,hisi-femac.yaml
@@ -22,6 +22,15 @@ properties:
       - description: The first region is the MAC core register base and size.
       - description: The second region is the global MAC control register.
 
+  ranges:
+    maxItems: 1
+
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 1
+
   interrupts:
     maxItems: 1
 
@@ -57,9 +66,16 @@ properties:
       - description: reset pulse for PHY
       - description: post-reset delay for PHY
 
+patternProperties:
+  'mdio@[0-9a-f]+':
+    $ref: hisilicon,hisi-femac-mdio.yaml#
+
 required:
   - compatible
   - reg
+  - ranges
+  - '#address-cells'
+  - '#size-cells'
   - interrupts
   - clocks
   - resets
@@ -75,6 +91,9 @@ examples:
     ethernet@10090000 {
         compatible = "hisilicon,hi3516cv300-femac";
         reg = <0x10090000 0x1000>, <0x10091300 0x200>;
+        ranges = <0x0 0x10090000 0x10000>;
+        #address-cells = <1>;
+        #size-cells = <1>;
         interrupts = <12>;
         clocks = <&clk_femac>, <&clk_femacif>, <&clk_fephy>;
         clock-names = "mac", "macif", "phy";
@@ -84,4 +103,15 @@ examples:
         phy-mode = "mii";
         phy-handle = <&fephy>;
         hisilicon,phy-reset-delays-us = <10000 20000 20000>;
+
+        mdio@1100 {
+            compatible = "hisilicon,hisi-femac-mdio";
+            reg = <0x1100 0x20>;
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            phy@1 {
+                reg = <1>;
+            };
+        };
     };

-- 
2.43.0


  parent reply	other threads:[~2024-03-07 11:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-07 11:34 [PATCH net-next v9 0/9] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 1/9] dt-bindings: net: hisilicon-femac-mdio: convert to YAML Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 2/9] dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 3/9] net: mdio: hisi-femac: remove clock Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 4/9] dt-bindings: net: convert hisi-femac.txt to YAML Yang Xiwen via B4 Relay
2024-03-08  7:59   ` Krzysztof Kozlowski
2024-03-07 11:34 ` Yang Xiwen via B4 Relay [this message]
2024-03-07 11:34 ` [PATCH net-next v9 6/9] dt-bindings: net: hisi-femac: add binding for Hi3798MV200 FEMAC core Yang Xiwen via B4 Relay
2024-03-07 22:11   ` Rob Herring
2024-03-08  8:01   ` Krzysztof Kozlowski
2024-03-08  8:02     ` Yang Xiwen
2024-03-08  8:40       ` Krzysztof Kozlowski
2024-03-07 11:34 ` [PATCH net-next v9 7/9] net: hisi_femac: remove unused compatible strings Yang Xiwen via B4 Relay
2024-03-07 11:34 ` [PATCH net-next v9 8/9] net: hisi_femac: add support for hisi_femac core on Hi3798MV200 Yang Xiwen via B4 Relay
2024-03-08  8:02   ` Krzysztof Kozlowski
2024-03-08  8:07     ` Yang Xiwen
2024-03-08  8:09       ` Krzysztof Kozlowski
2024-03-08  8:18         ` Yang Xiwen
2024-03-08  8:22           ` Krzysztof Kozlowski
2024-03-07 11:34 ` [PATCH net-next v9 9/9] net: hisi_femac: remove unneeded MODULE_ALIAS() Yang Xiwen via B4 Relay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240307-net-v9-5-6e0cf3e6584d@outlook.com \
    --to=devnull+forbidden405.outlook.com@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=forbidden405@outlook.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    --cc=salil.mehta@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).