From: Herve Codina <herve.codina@bootlin.com>
To: Yury Norov <yury.norov@gmail.com>
Cc: Vadim Fedorenko <vadim.fedorenko@linux.dev>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Andrew Lunn <andrew@lunn.ch>,
Mark Brown <broonie@kernel.org>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH v6 4/5] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support
Date: Thu, 7 Mar 2024 08:26:46 +0100 [thread overview]
Message-ID: <20240307082646.6e9198df@bootlin.com> (raw)
In-Reply-To: <ZehqRMZwtazTf6P6@yury-ThinkPad>
Hi Yury,
On Wed, 6 Mar 2024 05:06:12 -0800
Yury Norov <yury.norov@gmail.com> wrote:
...
> > +static int qmc_hdlc_xlate_ts_info(struct qmc_hdlc *qmc_hdlc,
> > + const struct qmc_chan_ts_info *ts_info, u32 *slot_map)
> > +{
> > + DECLARE_BITMAP(ts_mask_avail, 64);
> > + DECLARE_BITMAP(ts_mask, 64);
> > + DECLARE_BITMAP(map, 64);
> > + u32 array32[2];
>
> NIT. Bad name. I'd suggest slot_array, or something.
>
A new iteration of this series is planned.
I will change to slot_array as suggested.
Best regards,
Hervé
next prev parent reply other threads:[~2024-03-07 7:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 8:07 [PATCH v6 0/5] Add support for QMC HDLC Herve Codina
2024-03-06 8:07 ` [PATCH v6 1/5] net: wan: " Herve Codina
2024-03-06 10:56 ` Ratheesh Kannoth
2024-03-06 13:37 ` Herve Codina
2024-03-06 16:01 ` [EXTERNAL] " Ratheesh Kannoth
2024-03-06 16:22 ` Jakub Kicinski
2024-03-06 17:46 ` Herve Codina
2024-03-06 17:52 ` Jakub Kicinski
2024-03-06 13:27 ` Yury Norov
2024-03-06 13:38 ` Andy Shevchenko
2024-03-06 16:22 ` Jakub Kicinski
2024-03-06 8:07 ` [PATCH v6 2/5] MAINTAINERS: Add the Freescale QMC HDLC driver entry Herve Codina
2024-03-06 8:07 ` [PATCH v6 3/5] lib/bitmap: Introduce bitmap_scatter() and bitmap_gather() helpers Herve Codina
2024-03-06 13:11 ` Yury Norov
2024-03-06 13:39 ` Andy Shevchenko
2024-03-07 7:31 ` Herve Codina
2024-03-06 8:07 ` [PATCH v6 4/5] net: wan: fsl_qmc_hdlc: Add runtime timeslots changes support Herve Codina
2024-03-06 13:06 ` Yury Norov
2024-03-06 13:43 ` Andy Shevchenko
2024-03-06 15:43 ` Herve Codina
2024-03-06 15:55 ` Andy Shevchenko
2024-03-07 7:26 ` Herve Codina [this message]
2024-03-06 8:07 ` [PATCH v6 5/5] net: wan: fsl_qmc_hdlc: Add framer support Herve Codina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240307082646.6e9198df@bootlin.com \
--to=herve.codina@bootlin.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vadim.fedorenko@linux.dev \
--cc=yury.norov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).