netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCHv2 net-next] netlink: specs: support unterminated-ok
@ 2024-03-08  8:12 Hangbin Liu
  2024-03-09  3:57 ` Jakub Kicinski
  2024-03-11 20:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2024-03-08  8:12 UTC (permalink / raw)
  To: netdev
  Cc: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
	Hangbin Liu

ynl-gen-c.py supports check unterminated-ok, but the yaml schemas don't
have this key. Add this to the yaml files.

Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
v2: update subject, expand the doc and leave the change out of
    genetlink spec. (Jakub Kicinski)
---
 Documentation/netlink/genetlink-c.yaml      | 5 +++++
 Documentation/netlink/genetlink-legacy.yaml | 5 +++++
 Documentation/netlink/netlink-raw.yaml      | 5 +++++
 3 files changed, 15 insertions(+)

diff --git a/Documentation/netlink/genetlink-c.yaml b/Documentation/netlink/genetlink-c.yaml
index c58f7153fcf8..3b5e910f3606 100644
--- a/Documentation/netlink/genetlink-c.yaml
+++ b/Documentation/netlink/genetlink-c.yaml
@@ -208,6 +208,11 @@ properties:
                   exact-len:
                     description: Exact length for a string or a binary attribute.
                     $ref: '#/$defs/len-or-define'
+                  unterminated-ok:
+                    description: |
+                      For string attributes, do not check whether attribute
+                      contains the terminating null character.
+                    type: boolean
               sub-type: *attr-type
               display-hint: &display-hint
                 description: |
diff --git a/Documentation/netlink/genetlink-legacy.yaml b/Documentation/netlink/genetlink-legacy.yaml
index 938703088306..0f48c14a33d2 100644
--- a/Documentation/netlink/genetlink-legacy.yaml
+++ b/Documentation/netlink/genetlink-legacy.yaml
@@ -251,6 +251,11 @@ properties:
                   exact-len:
                     description: Exact length for a string or a binary attribute.
                     $ref: '#/$defs/len-or-define'
+                  unterminated-ok:
+                    description: |
+                      For string attributes, do not check whether attribute
+                      contains the terminating null character.
+                    type: boolean
               sub-type: *attr-type
               display-hint: *display-hint
               # Start genetlink-c
diff --git a/Documentation/netlink/netlink-raw.yaml b/Documentation/netlink/netlink-raw.yaml
index ac4e05415f2f..aa37af9f8a8c 100644
--- a/Documentation/netlink/netlink-raw.yaml
+++ b/Documentation/netlink/netlink-raw.yaml
@@ -270,6 +270,11 @@ properties:
                   exact-len:
                     description: Exact length for a string or a binary attribute.
                     $ref: '#/$defs/len-or-define'
+                  unterminated-ok:
+                    description: |
+                      For string attributes, do not check whether attribute
+                      contains the terminating null character.
+                    type: boolean
               sub-type: *attr-type
               display-hint: *display-hint
               # Start genetlink-c
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCHv2 net-next] netlink: specs: support unterminated-ok
  2024-03-08  8:12 [PATCHv2 net-next] netlink: specs: support unterminated-ok Hangbin Liu
@ 2024-03-09  3:57 ` Jakub Kicinski
  2024-03-11 20:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2024-03-09  3:57 UTC (permalink / raw)
  To: Hangbin Liu; +Cc: netdev, David S. Miller, Eric Dumazet, Paolo Abeni

On Fri,  8 Mar 2024 16:12:39 +0800 Hangbin Liu wrote:
> ynl-gen-c.py supports check unterminated-ok, but the yaml schemas don't
> have this key. Add this to the yaml files.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>

Reviewed-by: Jakub Kicinski <kuba@kernel.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCHv2 net-next] netlink: specs: support unterminated-ok
  2024-03-08  8:12 [PATCHv2 net-next] netlink: specs: support unterminated-ok Hangbin Liu
  2024-03-09  3:57 ` Jakub Kicinski
@ 2024-03-11 20:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-11 20:30 UTC (permalink / raw)
  To: Hangbin Liu; +Cc: netdev, davem, edumazet, kuba, pabeni

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri,  8 Mar 2024 16:12:39 +0800 you wrote:
> ynl-gen-c.py supports check unterminated-ok, but the yaml schemas don't
> have this key. Add this to the yaml files.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
> v2: update subject, expand the doc and leave the change out of
>     genetlink spec. (Jakub Kicinski)
> 
> [...]

Here is the summary with links:
  - [PATCHv2,net-next] netlink: specs: support unterminated-ok
    https://git.kernel.org/netdev/net-next/c/44208f59362e

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-03-11 20:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-08  8:12 [PATCHv2 net-next] netlink: specs: support unterminated-ok Hangbin Liu
2024-03-09  3:57 ` Jakub Kicinski
2024-03-11 20:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).