From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E73E25774; Fri, 8 Mar 2024 19:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709925766; cv=none; b=K7oLXBWBrc/6V6sqgFo3axL4wgZDcRBr5JaSbfMTIzVkwnQ8LagndnF9Rf49A7u3Ohufje03AtQyEsTG2JsV9p55heooSZ85xlB5nxyFDQTPDBbXGbRJmXi/vmyM57y6ZvfS0iRyqJ9MSMUKjIsMVtPoUpSZ8+s6cWxRBGw434I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709925766; c=relaxed/simple; bh=YeZa26lHQuEywHRgaJ3tIFPzhotZ2Y6RUoWM5+cEY0M=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Lwi2REX0GkSgXtkhbqSGmBQ3CNTHwgse2ZSJzAyhNVICuLa1qi9oo/ADUgQbod5NllSorjp+ezne23T39QSl6E4Svz2HhTACly/ejhwZbz2b2w0IoR5fLHBHrtRSbCLeGiTgQ3tmouCBquEcoBM3qdYI/Tj35S5W/n8hlEZqgVY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mLbL0vLh; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mLbL0vLh" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 91E6EC433C7; Fri, 8 Mar 2024 19:22:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709925766; bh=YeZa26lHQuEywHRgaJ3tIFPzhotZ2Y6RUoWM5+cEY0M=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=mLbL0vLh3uxjSc/tz2NW1uqzXYnWbKTsF5nd84lYxxnQfwMFNWjZz4eu9d4we7rYo 75ffhr8hWrPH3CJoYeotCnMMIZ/VdJA051iW4mRr7PKoXHxchiiDLR0UVPpaFNeoxx lSlbUyKA+DtFiLuMRT0YuELSqE1IbuozBgrnD7nJ4NwWiuPfJ48TSnELBbVE9sSE5G VGKsHQYawfJIGZmgF8N5IPP9GpslurnKFXS3WL/qIwlK4IySJW7rPzzrrZk81xthoa MRulNesxNJbP9SVv7Z5oSWu9ialLhrHodc+Ob83YyQNCdxZsjUYk01B5P1GNuZLZU/ e0Q6CoEY53dwQ== Date: Fri, 8 Mar 2024 11:22:44 -0800 From: Jakub Kicinski To: Haiyang Zhang Cc: Shradha Gupta , Shradha Gupta , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , Eric Dumazet , Paolo Abeni , Ajay Sharma , Leon Romanovsky , Thomas Gleixner , Sebastian Andrzej Siewior , KY Srinivasan , Wei Liu , Dexuan Cui , Long Li , Michael Kelley Subject: Re: [PATCH] net :mana : Add per-cpu stats for MANA device Message-ID: <20240308112244.391b3779@kernel.org> In-Reply-To: References: <1709823132-22411-1-git-send-email-shradhagupta@linux.microsoft.com> <20240307072923.6cc8a2ba@kernel.org> <20240307090145.2fc7aa2e@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 8 Mar 2024 18:51:58 +0000 Haiyang Zhang wrote: > > Dynamic is a bit of an exaggeration, right? On a well-configured system > > each CPU should use a single queue assigned thru XPS. And for manual > > debug bpftrace should serve the purpose quite well. > > Some programs, like irqbalancer can dynamically change the CPU affinity, > so we want to add the per-CPU counters for better understanding of the CPU > usage. Do you have experimental data showing this making a difference in production? Seems unlikely, but if it does work we should enable it for all devices, no driver by driver.