From: Jakub Kicinski <kuba@kernel.org>
To: Hangbin Liu <liuhangbin@gmail.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Jiri Pirko <jiri@resnulli.us>,
Donald Hunter <donald.hunter@gmail.com>,
Nicolas Dichtel <nicolas.dichtel@6wind.com>
Subject: Re: [PATCHv2 net-next] tools: ynl-gen: support using pre-defined values in attr checks
Date: Fri, 8 Mar 2024 11:38:18 -0800 [thread overview]
Message-ID: <20240308113818.6743abe1@kernel.org> (raw)
In-Reply-To: <20240307092357.1919830-1-liuhangbin@gmail.com>
On Thu, 7 Mar 2024 17:23:57 +0800 Hangbin Liu wrote:
> + for const in self.family['definitions']:
Looks like this breaks the build, the 'definitions' attribute
is optional. Try iterating over self.family.consts instead.
It should be initialized by nlspec.py to either the definitions
or an empty list, always.
--
pw-bot: cr
prev parent reply other threads:[~2024-03-08 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 9:23 [PATCHv2 net-next] tools: ynl-gen: support using pre-defined values in attr checks Hangbin Liu
2024-03-08 19:38 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308113818.6743abe1@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).