From: Jakub Kicinski <kuba@kernel.org>
To: Leone Fernando <leone4fernando@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
dsahern@kernel.org, willemb@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: dst_cache: add input_dst_cache API
Date: Fri, 8 Mar 2024 19:55:29 -0800 [thread overview]
Message-ID: <20240308195529.57b1a4fa@kernel.org> (raw)
In-Reply-To: <20240307171202.232684-3-leone4fernando@gmail.com>
On Thu, 7 Mar 2024 18:12:00 +0100 Leone Fernando wrote:
> +static inline u64 create_dst_cache_key_ip4(const struct sk_buff *skb)
> +{
> + struct iphdr *iphdr = ip_hdr(skb);
> +
> + return (((u64)iphdr->daddr) << 8) | iphdr->tos;
Sparse complains that you're ignoring bitwise types:
include/net/dst_cache.h:170:19: warning: cast from restricted __be32
include/net/dst_cache.h:170:19: warning: cast from restricted __be32
--
pw-bot: cr
next prev parent reply other threads:[~2024-03-09 3:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-07 17:11 [PATCH net-next 0/4] net: route: improve route hinting Leone Fernando
2024-03-07 17:11 ` [PATCH net-next 1/4] net: route: expire rt if the dst it holds is expired Leone Fernando
2024-03-07 17:12 ` [PATCH net-next 2/4] net: dst_cache: add input_dst_cache API Leone Fernando
2024-03-09 3:55 ` Jakub Kicinski [this message]
2024-03-14 14:04 ` Leone Fernando
2024-03-14 18:20 ` Jakub Kicinski
2024-03-07 17:12 ` [PATCH net-next 3/4] net: route: always compile dst_cache Leone Fernando
2024-03-07 17:12 ` [PATCH net-next 4/4] net: route: replace route hints with input_dst_cache Leone Fernando
2024-03-09 4:53 ` [PATCH net-next 0/4] net: route: improve route hinting David Ahern
2024-03-12 15:38 ` Leone Fernando
2024-04-02 10:08 ` Leone Fernando
2024-04-02 15:02 ` David Ahern
2024-04-03 11:50 ` Leone Fernando
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308195529.57b1a4fa@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=leone4fernando@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).