From: Jakub Kicinski <kuba@kernel.org>
To: William Tu <witu@nvidia.com>
Cc: <netdev@vger.kernel.org>, <jiri@nvidia.com>, <bodong@nvidia.com>
Subject: Re: [PATCH net-next] devlink: Add comments to use netlink gen tool
Date: Fri, 8 Mar 2024 20:15:15 -0800 [thread overview]
Message-ID: <20240308201515.3b4aef71@kernel.org> (raw)
In-Reply-To: <20240308001546.19010-1-witu@nvidia.com>
On Fri, 8 Mar 2024 02:15:46 +0200 William Tu wrote:
> - /* add new attributes above here, update the policy in devlink.c */
> + /* Add new attributes above here, update the spec in
> + * Documentation/netlink/specs/devlink.yaml and re-generate
> + * net/devlink/netlink_gen.c. */
>
Unless someone feels strongly I reckon we should heed checkpatch's
advice and put the */ on a separate line.
--
pw-bot: cr
next prev parent reply other threads:[~2024-03-09 4:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 0:15 [PATCH net-next] devlink: Add comments to use netlink gen tool William Tu
2024-03-09 4:15 ` Jakub Kicinski [this message]
2024-03-10 14:45 ` William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240308201515.3b4aef71@kernel.org \
--to=kuba@kernel.org \
--cc=bodong@nvidia.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=witu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).