* [PATCH net-next] devlink: Add comments to use netlink gen tool
@ 2024-03-08 0:15 William Tu
2024-03-09 4:15 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: William Tu @ 2024-03-08 0:15 UTC (permalink / raw)
To: netdev; +Cc: jiri, bodong, kuba, witu
Add the comment to remind people not to manually modify
the net/devlink/netlink_gen.c, but to use tools/net/ynl/ynl-regen.sh
to generate it.
Signed-off-by: William Tu <witu@nvidia.com>
Suggested-by: Jiri Pirko <jiri@nvidia.com>
---
include/uapi/linux/devlink.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index 130cae0d3e20..852ceb21ee69 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/devlink.h
@@ -614,7 +614,9 @@ enum devlink_attr {
DEVLINK_ATTR_REGION_DIRECT, /* flag */
- /* add new attributes above here, update the policy in devlink.c */
+ /* Add new attributes above here, update the spec in
+ * Documentation/netlink/specs/devlink.yaml and re-generate
+ * net/devlink/netlink_gen.c. */
__DEVLINK_ATTR_MAX,
DEVLINK_ATTR_MAX = __DEVLINK_ATTR_MAX - 1
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] devlink: Add comments to use netlink gen tool
2024-03-08 0:15 [PATCH net-next] devlink: Add comments to use netlink gen tool William Tu
@ 2024-03-09 4:15 ` Jakub Kicinski
2024-03-10 14:45 ` William Tu
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2024-03-09 4:15 UTC (permalink / raw)
To: William Tu; +Cc: netdev, jiri, bodong
On Fri, 8 Mar 2024 02:15:46 +0200 William Tu wrote:
> - /* add new attributes above here, update the policy in devlink.c */
> + /* Add new attributes above here, update the spec in
> + * Documentation/netlink/specs/devlink.yaml and re-generate
> + * net/devlink/netlink_gen.c. */
>
Unless someone feels strongly I reckon we should heed checkpatch's
advice and put the */ on a separate line.
--
pw-bot: cr
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] devlink: Add comments to use netlink gen tool
2024-03-09 4:15 ` Jakub Kicinski
@ 2024-03-10 14:45 ` William Tu
0 siblings, 0 replies; 3+ messages in thread
From: William Tu @ 2024-03-10 14:45 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: netdev, jiri, bodong
On 3/8/24 8:15 PM, Jakub Kicinski wrote:
> External email: Use caution opening links or attachments
>
>
> On Fri, 8 Mar 2024 02:15:46 +0200 William Tu wrote:
>> - /* add new attributes above here, update the policy in devlink.c */
>> + /* Add new attributes above here, update the spec in
>> + * Documentation/netlink/specs/devlink.yaml and re-generate
>> + * net/devlink/netlink_gen.c. */
>>
> Unless someone feels strongly I reckon we should heed checkpatch's
> advice and put the */ on a separate line.
> --
> pw-bot: cr
Will do, thanks
William
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-10 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-08 0:15 [PATCH net-next] devlink: Add comments to use netlink gen tool William Tu
2024-03-09 4:15 ` Jakub Kicinski
2024-03-10 14:45 ` William Tu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).