netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: William Tu <witu@nvidia.com>
Cc: <netdev@vger.kernel.org>, <jiri@nvidia.com>, <bodong@nvidia.com>,
	<tariqt@nvidia.com>, <yossiku@nvidia.com>
Subject: Re: [PATCH RFC v3 net-next 1/2] devlink: Add shared memory pool eswitch attribute
Date: Fri, 8 Mar 2024 20:44:31 -0800	[thread overview]
Message-ID: <20240308204431.36e56066@kernel.org> (raw)
In-Reply-To: <20240306231253.8100-1-witu@nvidia.com>

On Thu, 7 Mar 2024 01:12:52 +0200 William Tu wrote:
> When using switchdev mode, the representor ports handles the slow path
> traffic, the traffic that can't be offloaded will be redirected to the
> representor port for processing. Memory consumption of the representor
> port's rx buffer can grow to several GB when scaling to 1k VFs reps.
> For example, in mlx5 driver, each RQ, with a typical 1K descriptors,
> consumes 3MB of DMA memory for packet buffer in WQEs, and with four
> channels, it consumes 4 * 3MB * 1024 = 12GB of memory. And since rep
> ports are for slow path traffic, most of these rx DMA memory are idle.
> 
> Add spool_size configuration, allowing multiple representor ports
> to share a rx memory buffer pool. When enabled, individual representor
> doesn't need to allocate its dedicated rx buffer, but just pointing
> its rq to the memory pool. This could make the memory being better
> utilized. The spool_size represents the number of bytes of the memory
> pool. Users can adjust it based on how many reps, total system
> memory, or performance expectation.

We may need to wordsmith the docs once present but in general, FWIW:
Acked-by: Jakub Kicinski <kuba@kernel.org>

      parent reply	other threads:[~2024-03-09  4:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-06 23:12 [PATCH RFC v3 net-next 1/2] devlink: Add shared memory pool eswitch attribute William Tu
2024-03-06 23:12 ` [PATCH RFC v3 net-next 2/2] net/mlx5e: Add eswitch shared descriptor devlink William Tu
2024-03-07  8:35 ` [PATCH RFC v3 net-next 1/2] devlink: Add shared memory pool eswitch attribute Jiri Pirko
2024-03-08  0:16   ` William Tu
2024-03-09  4:44 ` Jakub Kicinski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240308204431.36e56066@kernel.org \
    --to=kuba@kernel.org \
    --cc=bodong@nvidia.com \
    --cc=jiri@nvidia.com \
    --cc=netdev@vger.kernel.org \
    --cc=tariqt@nvidia.com \
    --cc=witu@nvidia.com \
    --cc=yossiku@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).