From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F83015BE for ; Sat, 9 Mar 2024 17:09:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710004175; cv=none; b=XiohwcQyT14KhDtZetPvVL6JSZNmzt/4luU6o1ksO+K3WG4KztjI76/I4/qAis+btD/nZA3s7IiJR87EqR6/xulMV4Gb5kRiDX2X3C1JchtbFJxz4ystOO/IUnlqnjztlDPAf8xL+Fx02StjM07RpWyPn/JFX8MF66E7QkGdm0Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710004175; c=relaxed/simple; bh=3LtTJJAKkMJi9k3pEnpGML//0wkNiAxpHKQG7njIq9Y=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=bKMZEO03eXJ3vBTH+aK9PwsEAQoZhUW7mNk/hUYlqJ6dAE7+PvWp/QWv4RdZyEPFxuSsizYd9XKSK9C99LJpjcIJ7aXPkOzUQw+iQfFSnOhVtzP/3Nz2V0Zvo6kbgfCMIKw1GmZjBIei72Fa3MSxetktXjFcD8g/C1w38iKMh3E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org; spf=pass smtp.mailfrom=networkplumber.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b=pYrS0Ln3; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=networkplumber.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20230601.gappssmtp.com header.i=@networkplumber-org.20230601.gappssmtp.com header.b="pYrS0Ln3" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6e6092a84f4so2393087b3a.0 for ; Sat, 09 Mar 2024 09:09:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1710004173; x=1710608973; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=SHqXXAD6Bd7td3uOYjMjmxkJMM3dnF/Fwmd9qHYiur0=; b=pYrS0Ln3FOrgu1/Ay3ClydxWzWAzU7HqtDMvH1aWIND0MUnGCW58TcxF1EtXfRIKG+ +T0t1YaYbzDzLn3Q6G+VN0tuKRbPFfSd988coqYh15IXpUfJySE9JbiSAn6i76SGBQMc 8R3hPIXDVD5EGpUiTyygvghwQCoKKXHPaaluu2JssS5H8OkAv8vqc9Jx1JnZ7Z536NhL aAuNhBu+ZGY/W+Pm5xeEv5vHmQTzTNFE+WwMZHfE15LOTXEM4VR2AMH6luMo0TX47slD K6TWeyEFYY1dBsTaSQ9Q+JFWgaLmjbcv8yzdJXDMhxQl2na9lyauNpNJEQlVLKvYkD7t zBhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710004173; x=1710608973; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SHqXXAD6Bd7td3uOYjMjmxkJMM3dnF/Fwmd9qHYiur0=; b=qwTAYISWEIvPzhTBFJAeeIsVyDmo+/3bSGkuWg9luCbocT0TEBFOiXaR8WITa4oG4w 3EkaAeg5WvYHBTi87NrJoyV7TwsvBWS6G7ACZpsdJyfe6f/colMLQTpiuYO1vLD1H4Jw afy9zQLPBUvqBURxoOGAvyn5E+tzylxXhVXMKMc84J5+fSmHP4x9g9X9bCBKCQ4I6m9C DuTv2xBy+u4RKMN2pkYYy70IwzDdmdzXRMc9E+/VG9XF801MjkBQx3Dgl5wqemRf5Y1d fONYXbF4Lp0Wup16rjdLmqLlq6t50cy6pejKCgazRsDRCDlYDA+byIxwwF9inpKed5bf wuxQ== X-Forwarded-Encrypted: i=1; AJvYcCWA0QiAVf1BjeL51qmUygSGG4YPDvhSX3o+0hPaGsjvXDsMruEersOObn2yEkWkE8fylgaQHLr2HHVy+HlG3RYnVQA4F0QP X-Gm-Message-State: AOJu0YwFMmBsY8wIuOBWfCZZixXsf6Fj49u8pD0WI0Z10SE8gHFLvNGv /5ulh7+1l3/SPbE+CMLUjWNUBz0M0F0dA7VG8B0g+NZum87PPCGnfOeBDApkv+g= X-Google-Smtp-Source: AGHT+IF7Y1eftpCPunNKY4Vn+a7kmwiaPKByHoRXD9GXTyR07mOXokjvYu/FJibk+pnPc32Q/3RgTg== X-Received: by 2002:a05:6a00:812:b0:6e6:3920:7a26 with SMTP id m18-20020a056a00081200b006e639207a26mr2502722pfk.3.1710004173335; Sat, 09 Mar 2024 09:09:33 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id u16-20020aa78390000000b006e5dc1b4866sm1500380pfm.144.2024.03.09.09.09.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Mar 2024 09:09:33 -0800 (PST) Date: Sat, 9 Mar 2024 09:09:31 -0800 From: Stephen Hemminger To: Joe Perches Cc: Oleksij Rempel , Jiri Pirko , Ivan Vecera , "David S. Miller" , Andrew Lunn , Eric Dumazet , Florian Fainelli , Jakub Kicinski , Paolo Abeni , Vladimir Oltean , Simon Horman , kernel@pengutronix.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH net-next v2 1/1] net: bridge: switchdev: Improve error message clarity for switchdev_port_obj_add/del_deffered operations Message-ID: <20240309090931.16d8d58a@hermes.local> In-Reply-To: <4f38500b4d798ad8effd59fef41353439f76fec3.camel@perches.com> References: <20240308104725.2550469-1-o.rempel@pengutronix.de> <4f38500b4d798ad8effd59fef41353439f76fec3.camel@perches.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 09 Mar 2024 06:26:28 -0800 Joe Perches wrote: > > + problem = "Attempted operation is undefined, indicating a " > > + "possible programming error.\n"; > > My preference would be to write > problem = "Attempted operation is undefined indicating a possible programming error\n"; ETOOWORDY. Be concise please. problem = "Operations is undefined\n";