From: Jakub Kicinski <kuba@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Petr Machata <petrm@nvidia.com>, David Ahern <dsahern@kernel.org>,
<netdev@vger.kernel.org>, Ido Schimmel <idosch@nvidia.com>,
<mlxsw@nvidia.com>
Subject: Re: [PATCH iproute2-next 1/4] libnetlink: Add rta_getattr_uint()
Date: Sat, 9 Mar 2024 10:37:58 -0800 [thread overview]
Message-ID: <20240309103758.7bd0c249@kernel.org> (raw)
In-Reply-To: <20240309092158.5a8191dc@hermes.local>
On Sat, 9 Mar 2024 09:21:58 -0800 Stephen Hemminger wrote:
> > > Don't understand the use case here.
> > > The kernel always sends the same payload size for the same attribute.
> >
> > Please see commit 374d345d9b5e13380c in the kernel.
>
> Ok, but maybe go further and handle u16 and u8
I guess you can if that's helpful in iproute2, as a "universal getter",
cost of a few branches. In the kernel I try hard to convince people to
never use u8 and u16 as they simply waste space on padding, and the bits
may turn out to be needed later.
next prev parent reply other threads:[~2024-03-09 18:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-08 22:29 [PATCH iproute2-next 0/4] Support for nexthop group statistics Petr Machata
2024-03-08 22:29 ` [PATCH iproute2-next 1/4] libnetlink: Add rta_getattr_uint() Petr Machata
2024-03-08 22:58 ` Stephen Hemminger
2024-03-09 3:43 ` Jakub Kicinski
2024-03-09 17:21 ` Stephen Hemminger
2024-03-09 18:37 ` Jakub Kicinski [this message]
2024-03-11 10:53 ` Petr Machata
2024-03-08 22:29 ` [PATCH iproute2-next 2/4] ip: ipnexthop: Support dumping next hop group stats Petr Machata
2024-03-08 22:57 ` Stephen Hemminger
2024-03-08 22:29 ` [PATCH iproute2-next 3/4] ip: ipnexthop: Support dumping next hop group HW stats Petr Machata
2024-03-08 22:29 ` [PATCH iproute2-next 4/4] ip: ipnexthop: Allow toggling collection of nexthop group HW statistics Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240309103758.7bd0c249@kernel.org \
--to=kuba@kernel.org \
--cc=dsahern@kernel.org \
--cc=idosch@nvidia.com \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=petrm@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).