netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Angelo Daros de Luca <luizluca@gmail.com>
To: "Linus Walleij" <linus.walleij@linaro.org>,
	"Alvin Šipraga" <alsi@bang-olufsen.dk>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	 Luiz Angelo Daros de Luca <luizluca@gmail.com>,
	devicetree@vger.kernel.org
Subject: [PATCH net-next 1/4] dt-bindings: net: dsa: realtek: describe LED usage
Date: Sun, 10 Mar 2024 01:51:58 -0300	[thread overview]
Message-ID: <20240310-realtek-led-v1-1-4d9813ce938e@gmail.com> (raw)
In-Reply-To: <20240310-realtek-led-v1-0-4d9813ce938e@gmail.com>

Each port can have up to 4 LEDs (3 for current rtl8365mb devices). The
LED reg property will indicate its LED group.

An example of LED usage was included in an existing switch example.

Cc: devicetree@vger.kernel.org
Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
---
 .../devicetree/bindings/net/dsa/realtek.yaml       | 46 ++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/dsa/realtek.yaml b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
index 70b6bda3cf98..45c1656b3fae 100644
--- a/Documentation/devicetree/bindings/net/dsa/realtek.yaml
+++ b/Documentation/devicetree/bindings/net/dsa/realtek.yaml
@@ -108,6 +108,32 @@ properties:
       compatible:
         const: realtek,smi-mdio
 
+patternProperties:
+  '^(ethernet-)?ports$':
+    type: object
+    additionalProperties: true
+
+    patternProperties:
+      '^(ethernet-)?port@[0-6]$':
+        type: object
+        additionalProperties: true
+
+        properties:
+          leds:
+            description:
+              "LEDs associated with this port"
+
+            patternProperties:
+              '^led@[a-f0-9]+$':
+                type: object
+                additionalProperties: true
+
+                properties:
+                  reg:
+                    description:
+                      "reg indicates the LED group for this LED"
+                    enum: [0, 1, 2, 3]
+
 if:
   required:
     - reg
@@ -144,6 +170,7 @@ unevaluatedProperties: false
 examples:
   - |
     #include <dt-bindings/gpio/gpio.h>
+    #include <dt-bindings/leds/common.h>
     #include <dt-bindings/interrupt-controller/irq.h>
 
     platform {
@@ -190,6 +217,25 @@ examples:
                                     reg = <4>;
                                     label = "wan";
                                     phy-handle = <&phy4>;
+
+                                    leds {
+                                            #address-cells = <1>;
+                                            #size-cells = <0>;
+
+                                            led@0 {
+                                                    reg = <0>;
+                                                    color = <LED_COLOR_ID_GREEN>;
+                                                    function = LED_FUNCTION_WAN;
+                                                    default-state = "keep";
+                                            };
+
+                                            led@3 {
+                                                    reg = <3>;
+                                                    color = <LED_COLOR_ID_AMBER>;
+                                                    function = LED_FUNCTION_WAN;
+                                                    default-state = "keep";
+                                            };
+                                    };
                             };
                             port@5 {
                                     reg = <5>;

-- 
2.44.0


  reply	other threads:[~2024-03-10  4:52 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-10  4:51 [PATCH net-next 0/4] net: dsa: realtek: fix LED support for rtl8366 Luiz Angelo Daros de Luca
2024-03-10  4:51 ` Luiz Angelo Daros de Luca [this message]
2024-03-10  8:34   ` [PATCH net-next 1/4] dt-bindings: net: dsa: realtek: describe LED usage Krzysztof Kozlowski
2024-03-21 11:56     ` Luiz Angelo Daros de Luca
2024-03-21 12:18       ` Krzysztof Kozlowski
2024-03-24  2:10         ` Luiz Angelo Daros de Luca
2024-03-25  7:41           ` Krzysztof Kozlowski
2024-03-10 18:02   ` Andrew Lunn
2024-03-21 12:03     ` Luiz Angelo Daros de Luca
2024-03-10 18:31   ` Linus Walleij
2024-03-21 11:57     ` Luiz Angelo Daros de Luca
2024-03-10 18:52   ` Andrew Lunn
2024-03-21 11:58     ` Luiz Angelo Daros de Luca
2024-03-10 23:08   ` Rob Herring
2024-03-21 12:00     ` Luiz Angelo Daros de Luca
2024-03-10  4:51 ` [PATCH net-next 2/4] net: dsa: realtek: keep default LED state in rtl8366rb Luiz Angelo Daros de Luca
2024-03-10  8:01   ` Krzysztof Kozlowski
2024-03-10 11:37     ` Simon Horman
2024-03-10 11:47       ` Krzysztof Kozlowski
2024-03-11 16:11         ` Jakub Kicinski
2024-03-11 16:19           ` Krzysztof Kozlowski
2024-03-11 17:14             ` Jakub Kicinski
2024-03-11 18:40           ` Konstantin Ryabitsev
2024-03-11 18:52             ` Jakub Kicinski
2024-03-11 19:11               ` Konstantin Ryabitsev
2024-03-10  4:52 ` [PATCH net-next 3/4] net: dsa: realtek: do not assert reset on remove Luiz Angelo Daros de Luca
2024-03-10 18:33   ` Linus Walleij
2024-03-10  4:52 ` [PATCH net-next 4/4] net: dsa: realtek: add LED drivers for rtl8366rb Luiz Angelo Daros de Luca
2024-03-10  8:02   ` Krzysztof Kozlowski
2024-03-10 11:49   ` Simon Horman
2024-03-24  2:31     ` Luiz Angelo Daros de Luca
2024-03-10 18:47   ` Andrew Lunn
2024-03-24  3:46     ` Luiz Angelo Daros de Luca
2024-03-24 15:32       ` Andrew Lunn
2024-03-25  2:50         ` Luiz Angelo Daros de Luca
2024-03-25 12:38           ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240310-realtek-led-v1-1-4d9813ce938e@gmail.com \
    --to=luizluca@gmail.com \
    --cc=alsi@bang-olufsen.dk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).