From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F3554122D; Mon, 11 Mar 2024 15:51:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710172288; cv=none; b=KUOypfXMKv3iE6R3dMLXBl1hkCEEFbBNeyWOYWRFLZ8kfBn0xI7nPDE8ahUs5wpDTlywEr93p7F67iMTlhkF2u6ISclGeHQCMJwHMRVZsG+ygwWrCK/DbATnvJrcW7n/kKdWNV/GL93dKPfRUfww0TRCBJPyqmMEus/O8/NIPOo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710172288; c=relaxed/simple; bh=XNWhsq6o7ciElMMRkGWuW4CuG+Gx1UWKBsIqAvIJeAw=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KtFK7hxPntoExM1XF9kgwTTp0PQ2amfIqX5Vf9gEGzWBM+HUHC1jQshPR233lvucnSfavV41DDN/6+WEFKvFnG2b5HoXl7oxWrKWeHwYweWgcfi8R8GtYcXHTd66f/sNC18Hs9fZAJLWb5RmIlVc4jhZcBeBVpu3cIYSMNOg9VE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kpGMOAXp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kpGMOAXp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4B4A9C433F1; Mon, 11 Mar 2024 15:51:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1710172288; bh=XNWhsq6o7ciElMMRkGWuW4CuG+Gx1UWKBsIqAvIJeAw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=kpGMOAXpJd25+8/IDUvs7hkHrVGyOW6NfVYglOWk/RwNhFzrQ2GSeud23Rm9VZO7R 9F5zSzq4yGwAucDuKT86FY5pN/TzwGALGUogfrEKZkHdHumPRyPbO2WOurexMIkB2I 8Pij0GupcDlvtw3rJSwiHrbT9o6scfcuhAm+8gMiPtZl/A0humI6ohxO411uSVmH7B Twz+tHq368LwzdhzMxzrcM16Bvx0rQCoFcnWWFjhov/kHYK8H+GQoUxJjGxbIF8bNL cVLLGZzvcUy1V2KMIGmSCjMOuqnEaNyO+hgyWmE69rKeg4/ntNG7NVC0hKay5M4u8/ e67Ax6Uk7zMiQ== Date: Mon, 11 Mar 2024 08:51:26 -0700 From: Jakub Kicinski To: Shradha Gupta Cc: Haiyang Zhang , Shradha Gupta , "linux-kernel@vger.kernel.org" , "linux-hyperv@vger.kernel.org" , "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , Eric Dumazet , Paolo Abeni , Ajay Sharma , Leon Romanovsky , Thomas Gleixner , Sebastian Andrzej Siewior , KY Srinivasan , Wei Liu , Dexuan Cui , Long Li , Michael Kelley Subject: Re: [PATCH] net :mana : Add per-cpu stats for MANA device Message-ID: <20240311085126.648f42e0@kernel.org> In-Reply-To: <20240311041950.GA19647@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1709823132-22411-1-git-send-email-shradhagupta@linux.microsoft.com> <20240307072923.6cc8a2ba@kernel.org> <20240307090145.2fc7aa2e@kernel.org> <20240308112244.391b3779@kernel.org> <20240311041950.GA19647@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sun, 10 Mar 2024 21:19:50 -0700 Shradha Gupta wrote: > > Seems unlikely, but if it does work we should enable it for all > > devices, no driver by driver. > You mean, if the usecase seems valid we should try to extend the framework > mentioned by Rahul (https://lore.kernel.org/lkml/20240307072923.6cc8a2ba@kernel.org/) > to include these stats as well? "framework" is a big word, but yes, add a netlink command to get pcpu stats. Let's focus on the usefulness before investing time in a rewrite, tho.