From: Jakub Kicinski <kuba@kernel.org>
To: Yang Xiwen <forbidden405@outlook.com>
Cc: Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH net-next v11 4/9] dt-bindings: net: convert hisi-femac.txt to YAML
Date: Mon, 11 Mar 2024 09:03:41 -0700 [thread overview]
Message-ID: <20240311090341.32509303@kernel.org> (raw)
In-Reply-To: <SEZPR06MB6959090F2C45C3E5D6B3F9F496262@SEZPR06MB6959.apcprd06.prod.outlook.com>
On Sat, 9 Mar 2024 20:30:21 +0800 Yang Xiwen wrote:
> > + clock-names:
> > + items:
> > + - const: mac
> > + - const: macif
> > + - const: phy
>
> Still not very correct here. In downstream the core can also have an
> external PHY. The internal phy is also optional. So maybe this clock
> should be optional.
You are responding to yourself 4 min after posting?
What is the purpose of your comments?
next prev parent reply other threads:[~2024-03-11 16:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-09 12:26 [PATCH net-next v11 0/9] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles Yang Xiwen via B4 Relay
2024-03-09 12:26 ` [PATCH net-next v11 1/9] dt-bindings: net: hisilicon-femac-mdio: convert to YAML Yang Xiwen via B4 Relay
2024-03-09 12:26 ` [PATCH net-next v11 2/9] dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks Yang Xiwen via B4 Relay
2024-03-09 12:26 ` [PATCH net-next v11 3/9] net: mdio: hisi-femac: remove clock Yang Xiwen via B4 Relay
2024-03-09 12:26 ` [PATCH net-next v11 4/9] dt-bindings: net: convert hisi-femac.txt to YAML Yang Xiwen via B4 Relay
2024-03-09 12:30 ` Yang Xiwen
2024-03-11 16:03 ` Jakub Kicinski [this message]
2024-03-12 0:49 ` Yang Xiwen
2024-03-12 1:08 ` Jakub Kicinski
2024-03-12 1:15 ` Yang Xiwen
2024-03-09 12:26 ` [PATCH net-next v11 5/9] dt-bindings: net: hisi-femac: add mandatory MDIO bus subnode Yang Xiwen via B4 Relay
2024-03-09 12:26 ` [PATCH net-next v11 6/9] dt-bindings: net: hisi-femac: add binding for Hi3798MV200 FEMAC core Yang Xiwen via B4 Relay
2024-03-09 12:26 ` [PATCH net-next v11 7/9] net: hisi_femac: remove unused compatible strings Yang Xiwen via B4 Relay
2024-03-09 12:26 ` [PATCH net-next v11 8/9] net: hisi_femac: add support for hisi_femac core on Hi3798MV200 Yang Xiwen via B4 Relay
2024-03-09 12:26 ` [PATCH net-next v11 9/9] net: hisi_femac: remove unneeded MODULE_ALIAS() Yang Xiwen via B4 Relay
2024-04-12 6:47 ` [PATCH net-next v11 0/9] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles Yang Xiwen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311090341.32509303@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=forbidden405@outlook.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).