From: Simon Horman <horms@kernel.org>
To: William Tu <witu@nvidia.com>
Cc: netdev@vger.kernel.org, jiri@nvidia.com, bodong@nvidia.com
Subject: Re: [PATCH net] devlink: Fix length of eswitch inline-mode
Date: Mon, 11 Mar 2024 09:19:59 +0000 [thread overview]
Message-ID: <20240311091959.GB24043@kernel.org> (raw)
In-Reply-To: <20240310164547.35219-1-witu@nvidia.com>
On Sun, Mar 10, 2024 at 06:45:47PM +0200, William Tu wrote:
> Set eswitch inline-mode to be u8, not u16. Otherwise, errors below
>
> $ devlink dev eswitch set pci/0000:08:00.0 mode switchdev \
> inline-mode network
> Error: Attribute failed policy validation.
> kernel answers: Numerical result out of rang
> netlink: 'devlink': attribute type 26 has an invalid length.
>
> Fixes: f2f9dd164db0 ("netlink: specs: devlink: add the remaining command to generate complete split_ops")
> Signed-off-by: William Tu <witu@nvidia.com>
> ---
> Or we can fix the iproute2 to use u16?
My understanding is that it was u8, prior to changes moving the
code to use specs, so I think that fixing the kernel to once again use u8
is appropriate.
Reviewed-by: Simon Horman <horms@kernel.org>
...
next prev parent reply other threads:[~2024-03-11 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 16:45 [PATCH net] devlink: Fix length of eswitch inline-mode William Tu
2024-03-11 8:34 ` Jiri Pirko
2024-03-11 9:19 ` Simon Horman [this message]
2024-03-11 23:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311091959.GB24043@kernel.org \
--to=horms@kernel.org \
--cc=bodong@nvidia.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=witu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).