From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: Jiri Pirko <jiri@resnulli.us>,
netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next v1] netdevsim: replace pr_err with {dev,netdev,}_err wherever possible
Date: Mon, 11 Mar 2024 13:07:06 -0700 [thread overview]
Message-ID: <20240311130706.09f35fdd@kernel.org> (raw)
In-Reply-To: <20240310015215.4011872-1-dw@davidwei.uk>
On Sat, 9 Mar 2024 17:52:15 -0800 David Wei wrote:
> - pr_err("Failed to get snapshot id\n");
> + dev_err(&nsim_dev->nsim_bus_dev->dev, "Failed to get snapshot id\n");
We seem to use dev_err(&nsim_dev->nsim_bus_dev->dev, ...
in quite a few places after this patch, how about we add a wrapper
#define nsim_err(ns_dev, args...) \
dev_err(&(ns_dev)->nsim_bus_dev->dev(dev), ##args)
?
--
pw-bot: cr
next prev parent reply other threads:[~2024-03-11 20:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-10 1:52 [PATCH net-next v1] netdevsim: replace pr_err with {dev,netdev,}_err wherever possible David Wei
2024-03-11 9:28 ` Simon Horman
2024-03-11 20:07 ` Jakub Kicinski [this message]
2024-03-12 22:04 ` David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311130706.09f35fdd@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).