From: Jakub Kicinski <kuba@kernel.org>
To: "Asbjørn Sloth Tønnesen" <ast@fiberby.net>
Cc: Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Daniel Borkmann <daniel@iogearbox.net>,
Vlad Buslov <vladbu@nvidia.com>,
Marcelo Ricardo Leitner <mleitner@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
llu@fiberby.dk
Subject: Re: [PATCH net-next v3 0/3] make skip_sw actually skip software
Date: Mon, 11 Mar 2024 13:44:35 -0700 [thread overview]
Message-ID: <20240311134435.19393f98@kernel.org> (raw)
In-Reply-To: <20240306165813.656931-1-ast@fiberby.net>
On Wed, 6 Mar 2024 16:58:08 +0000 Asbjørn Sloth Tønnesen wrote:
> During development of flower-route[1], which I
> recently presented at FOSDEM[2], I noticed that
> CPU usage, would increase the more rules I installed
> into the hardware for IP forwarding offloading.
>
> Since we use TC flower offload for the hottest
> prefixes, and leave the long tail to the normal (non-TC)
> Linux network stack for slow-path IP forwarding.
> We therefore need both the hardware and software
> datapath to perform well.
>
> I found that skip_sw rules, are quite expensive
> in the kernel datapath, since they must be evaluated
> and matched upon, before the kernel checks the
> skip_sw flag.
>
> This patchset optimizes the case where all rules
> are skip_sw, by implementing a TC bypass for these
> cases, where TC is only used as a control plane
> for the hardware path.
Linus tagged v6.8 and the merge window for v6.9 has started.
This feels a bit too risky for me to apply last minute,
could you repost in 2 weeks once the merge window is over?
--
pw-bot: defer
next prev parent reply other threads:[~2024-03-11 20:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 16:58 [PATCH net-next v3 0/3] make skip_sw actually skip software Asbjørn Sloth Tønnesen
2024-03-06 16:58 ` [PATCH net-next v3 1/3] net: sched: cls_api: add skip_sw counter Asbjørn Sloth Tønnesen
2024-03-06 16:58 ` [PATCH net-next v3 2/3] net: sched: cls_api: add filter counter Asbjørn Sloth Tønnesen
2024-03-06 16:58 ` [PATCH net-next v3 3/3] net: sched: make skip_sw actually skip software Asbjørn Sloth Tønnesen
2024-03-11 20:44 ` Jakub Kicinski [this message]
2024-03-11 22:05 ` [PATCH net-next v3 0/3] " Asbjørn Sloth Tønnesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311134435.19393f98@kernel.org \
--to=kuba@kernel.org \
--cc=ast@fiberby.net \
--cc=daniel@iogearbox.net \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=llu@fiberby.dk \
--cc=mleitner@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vladbu@nvidia.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).