From: Jakub Kicinski <kuba@kernel.org>
To: Subbaraya Sundeep <sbhatta@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<sgoutham@marvell.com>, <lcherian@marvell.com>,
<gakula@marvell.com>, <hkelam@marvell.com>, <naveenm@marvell.com>,
<horms@kernel.org>
Subject: Re: [net PATCH 1/5] octeontx2: Detect the mbox up or down message via register
Date: Mon, 11 Mar 2024 15:58:18 -0700 [thread overview]
Message-ID: <20240311155818.03e20c05@kernel.org> (raw)
In-Reply-To: <1710184612-29027-2-git-send-email-sbhatta@marvell.com>
On Tue, 12 Mar 2024 00:46:48 +0530 Subbaraya Sundeep wrote:
> static int mcs_notify_pfvf(struct mcs_intr_event *event, struct rvu *rvu)
> {
> struct mcs_intr_info *req;
> - int err, pf;
> + int pf;
>
> pf = rvu_get_pf(event->pcifunc);
>
> + mutex_lock(&rvu->mbox_lock);
> +
> req = otx2_mbox_alloc_msg_mcs_intr_notify(rvu, pf);
> if (!req)
> return -ENOMEM;
missing unlock here?
> @@ -135,10 +137,11 @@ static int mcs_notify_pfvf(struct mcs_intr_event *event, struct rvu *rvu)
> req->hdr.pcifunc = event->pcifunc;
> req->lmac_id = event->lmac_id;
>
> - otx2_mbox_msg_send(&rvu->afpf_wq_info.mbox_up, pf);
> - err = otx2_mbox_wait_for_rsp(&rvu->afpf_wq_info.mbox_up, pf);
> - if (err)
> - dev_warn(rvu->dev, "MCS notification to pf %d failed\n", pf);
> + otx2_mbox_wait_for_zero(&rvu->afpf_wq_info.mbox_up, pf);
> +
> + otx2_mbox_msg_send_up(&rvu->afpf_wq_info.mbox_up, pf);
> +
> + mutex_unlock(&rvu->mbox_lock);
--
pw-bot: cr
next prev parent reply other threads:[~2024-03-11 22:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 19:16 [net PATCH 0/5] octeontx2-pf: RVU Mailbox fixes Subbaraya Sundeep
2024-03-11 19:16 ` [net PATCH 1/5] octeontx2: Detect the mbox up or down message via register Subbaraya Sundeep
2024-03-11 22:58 ` Jakub Kicinski [this message]
2024-03-12 11:22 ` Paolo Abeni
2024-03-12 11:49 ` [EXTERNAL] " Subbaraya Sundeep Bhatta
2024-03-11 19:16 ` [net PATCH 2/5] octeontx2-pf: Wait till detach_resources msg is complete Subbaraya Sundeep
2024-03-11 19:16 ` [net PATCH 3/5] octeontx2-pf: Use default max_active works instead of one Subbaraya Sundeep
2024-03-11 19:16 ` [net PATCH 4/5] octeontx2-pf: Send UP messages to VF only when VF is up Subbaraya Sundeep
2024-03-11 19:16 ` [net PATCH 5/5] octeontx2-af: Use separate handlers for interrupts Subbaraya Sundeep
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240311155818.03e20c05@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).