From: Florian Westphal <fw@strlen.de>
To: Chenyuan Yang <chenyuan0y@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, horms@kernel.org,
anjali.k.kulkarni@oracle.com, pctammela@mojatatu.com,
andriy.shevchenko@linux.intel.com, dhowells@redhat.com,
kuniyu@amazon.com, netdev@vger.kernel.org, zzjas98@gmail.com
Subject: Re: [net/netlink] Question about potential memleak in netlink_proto_init()
Date: Fri, 15 Mar 2024 01:53:47 +0100 [thread overview]
Message-ID: <20240315005347.GA8896@breakpoint.cc> (raw)
In-Reply-To: <ZfOalln/myRNOkH6@cy-server>
Chenyuan Yang <chenyuan0y@gmail.com> wrote:
> Dear Netlink Developers,
>
> We are curious whether the function `netlink_proto_init()` might have a memory leak.
Yes, but
> The function is https://elixir.bootlin.com/linux/v6.8/source/net/netlink/af_netlink.c#L2908
> and the relevant code is
> ```
> static int __init netlink_proto_init(void)
> {
> int i;
> ...
>
> for (i = 0; i < MAX_LINKS; i++) {
> if (rhashtable_init(&nl_table[i].hash,
> &netlink_rhashtable_params) < 0) {
> while (--i > 0)
> rhashtable_destroy(&nl_table[i].hash);
> kfree(nl_table);
> goto panic;
... this calls panic(), kernel will crash intentionally.
Perhaps best patch would be to remove this error handling
and panic straight away, this is pretty much dead code.
next prev parent reply other threads:[~2024-03-15 0:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-15 0:47 [net/netlink] Question about potential memleak in netlink_proto_init() Chenyuan Yang
2024-03-15 0:53 ` Florian Westphal [this message]
2024-03-15 0:54 ` Kuniyuki Iwashima
2024-03-15 14:36 ` Andy Shevchenko
2024-03-16 15:11 ` Chenyuan Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240315005347.GA8896@breakpoint.cc \
--to=fw@strlen.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anjali.k.kulkarni@oracle.com \
--cc=chenyuan0y@gmail.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=kuniyu@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=zzjas98@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).