From: Jakub Kicinski <kuba@kernel.org>
To: <xu.xin16@zte.com.cn>
Cc: <edumazet@google.com>, <davem@davemloft.net>,
<rostedt@goodmis.org>, <mhiramat@kernel.org>,
<dsahern@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-trace-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<yang.yang29@zte.com.cn>, <he.peilin@zte.com.cn>,
<liu.chun2@zte.com.cn>, <jiang.xuexin@zte.com.cn>,
<zhang.yunkai@zte.com.cn>
Subject: Re: [PATCH v3 resend] net/ipv4: add tracepoint for icmp_send
Date: Wed, 20 Mar 2024 20:44:23 -0700 [thread overview]
Message-ID: <20240320204423.270570c2@kernel.org> (raw)
In-Reply-To: <202403211109183894466@zte.com.cn>
On Thu, 21 Mar 2024 11:09:18 +0800 (CST) xu.xin16@zte.com.cn wrote:
> +/* This part must be outside protection */
> +#include <trace/define_trace.h>
> \ No newline at end of file
In addition to Jason's comments please make sure there is a new line at
the end of the file.
And please post v4 on Monday, net-next is currently closed.
While you wait have a read of:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html
:)
next prev parent reply other threads:[~2024-03-21 3:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 3:09 [PATCH v3 resend] net/ipv4: add tracepoint for icmp_send xu.xin16
2024-03-21 3:26 ` Jason Xing
2024-03-25 3:57 ` Peilin He
2024-03-25 4:04 ` Peilin He
2024-03-25 5:34 ` Jason Xing
2024-03-25 7:57 ` Peilin He
2024-03-21 3:44 ` Jakub Kicinski [this message]
2024-03-21 8:46 ` Eric Dumazet
2024-03-25 4:01 ` Peilin He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240320204423.270570c2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=he.peilin@zte.com.cn \
--cc=jiang.xuexin@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=liu.chun2@zte.com.cn \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=xu.xin16@zte.com.cn \
--cc=yang.yang29@zte.com.cn \
--cc=zhang.yunkai@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).