* Re: [PATCH] netlink: fix typo
2024-03-22 7:24 [PATCH] netlink: fix typo gaoxingwang
@ 2024-03-22 7:58 ` Jason Xing
2024-03-22 8:13 ` Jiri Pirko
2024-03-22 8:14 ` [PATCH] netlink: fix typo Jiri Pirko
2 siblings, 0 replies; 11+ messages in thread
From: Jason Xing @ 2024-03-22 7:58 UTC (permalink / raw)
To: gaoxingwang; +Cc: mkubecek, idosch, netdev, linux-kernel, yanan, liaichun
On Fri, Mar 22, 2024 at 3:26 PM gaoxingwang <gaoxingwang1@huawei.com> wrote:
>
> Add missing colon in coalesce_reply_cb
>
> Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)
This commit cannot be found in net/net-next tree...
> Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>
> Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
nit: two duplicated SoB
> ---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c
Where is this file? I suspect you're not using the standard mainline?
> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> - show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> + show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> show_cr();
>
> --
> 2.27.0
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] netlink: fix typo
2024-03-22 7:24 [PATCH] netlink: fix typo gaoxingwang
2024-03-22 7:58 ` Jason Xing
@ 2024-03-22 8:13 ` Jiri Pirko
2024-03-22 8:49 ` Michal Kubecek
2024-03-22 8:14 ` [PATCH] netlink: fix typo Jiri Pirko
2 siblings, 1 reply; 11+ messages in thread
From: Jiri Pirko @ 2024-03-22 8:13 UTC (permalink / raw)
To: gaoxingwang; +Cc: mkubecek, idosch, netdev, linux-kernel, yanan, liaichun
Fri, Mar 22, 2024 at 08:24:56AM CET, gaoxingwang1@huawei.com wrote:
>Add missing colon in coalesce_reply_cb
>
>Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)
>Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>
>Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/netlink/coalesce.c b/netlink/coalesce.c
>index bc34d3d..bb93f9b 100644
>--- a/netlink/coalesce.c
>+++ b/netlink/coalesce.c
Please make clear indication which project/tree you target with your
patch by putting appropriate name in the [patch NAME] brackets
>@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
>- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
>+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> show_cr();
>
>--
>2.27.0
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] netlink: fix typo
2024-03-22 8:13 ` Jiri Pirko
@ 2024-03-22 8:49 ` Michal Kubecek
2024-03-23 7:16 ` gaoxingwang
0 siblings, 1 reply; 11+ messages in thread
From: Michal Kubecek @ 2024-03-22 8:49 UTC (permalink / raw)
To: Jiri Pirko; +Cc: gaoxingwang, idosch, netdev, linux-kernel, yanan, liaichun
[-- Attachment #1: Type: text/plain, Size: 251 bytes --]
On Fri, Mar 22, 2024 at 09:13:53AM +0100, Jiri Pirko wrote:
> Please make clear indication which project/tree you target with your
> patch by putting appropriate name in the [patch NAME] brackets
In this case, it should be "[PATCH ethtool]".
Michal
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] netlink: fix typo
2024-03-22 8:49 ` Michal Kubecek
@ 2024-03-23 7:16 ` gaoxingwang
2024-03-23 7:27 ` [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb() gaoxingwang
0 siblings, 1 reply; 11+ messages in thread
From: gaoxingwang @ 2024-03-23 7:16 UTC (permalink / raw)
To: mkubecek; +Cc: idosch, jiri, liaichun, linux-kernel, netdev, yanan
>> Please make clear indication which project/tree you target with your
>> patch by putting appropriate name in the [patch NAME] brackets
>
>In this case, it should be "[PATCH ethtool]".
>
>Michal
Yes, this is a commit for the ethtool project. First time contributing a patch to this project, not familiar with it yet.
Thank you all or your guidance. I'll resubmit the patch later.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()
2024-03-23 7:16 ` gaoxingwang
@ 2024-03-23 7:27 ` gaoxingwang
0 siblings, 0 replies; 11+ messages in thread
From: gaoxingwang @ 2024-03-23 7:27 UTC (permalink / raw)
To: gaoxingwang1
Cc: idosch, jiri, liaichun, linux-kernel, mkubecek, netdev, yanan
Add missing colon in coalesce_reply_cb()
Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
---
netlink/coalesce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/netlink/coalesce.c b/netlink/coalesce.c
index bc34d3d..bb93f9b 100644
--- a/netlink/coalesce.c
+++ b/netlink/coalesce.c
@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
show_cr();
--
2.27.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] netlink: fix typo
2024-03-22 7:24 [PATCH] netlink: fix typo gaoxingwang
2024-03-22 7:58 ` Jason Xing
2024-03-22 8:13 ` Jiri Pirko
@ 2024-03-22 8:14 ` Jiri Pirko
2024-03-22 15:07 ` Jakub Kicinski
2 siblings, 1 reply; 11+ messages in thread
From: Jiri Pirko @ 2024-03-22 8:14 UTC (permalink / raw)
To: gaoxingwang; +Cc: mkubecek, idosch, netdev, linux-kernel, yanan, liaichun
Fri, Mar 22, 2024 at 08:24:56AM CET, gaoxingwang1@huawei.com wrote:
>Add missing colon in coalesce_reply_cb
>
>Fixes: ec573f209d (netlink: settings: add netlink support for coalesce tx aggr params)
>Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
>
>Signed-off-by: gaoxingwang <gaoxingwang1@huawei.com>
Also, please make sure your name is properly formatted. "gaoxingwang"
certainly is not.
>---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/netlink/coalesce.c b/netlink/coalesce.c
>index bc34d3d..bb93f9b 100644
>--- a/netlink/coalesce.c
>+++ b/netlink/coalesce.c
>@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
>- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
>+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> show_cr();
>
>--
>2.27.0
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PATCH] netlink: fix typo
2024-03-22 8:14 ` [PATCH] netlink: fix typo Jiri Pirko
@ 2024-03-22 15:07 ` Jakub Kicinski
2024-04-02 11:16 ` Jiri Pirko
0 siblings, 1 reply; 11+ messages in thread
From: Jakub Kicinski @ 2024-03-22 15:07 UTC (permalink / raw)
To: Jiri Pirko
Cc: gaoxingwang, mkubecek, idosch, netdev, linux-kernel, yanan,
liaichun
On Fri, 22 Mar 2024 09:14:39 +0100 Jiri Pirko wrote:
> "gaoxingwang" certainly is not.
According to what rules? Honest question, I don't know much about
transliteration of what I guess is a Chinese name.
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] netlink: fix typo
2024-03-22 15:07 ` Jakub Kicinski
@ 2024-04-02 11:16 ` Jiri Pirko
2024-04-02 12:16 ` [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb() gaoxingwang
0 siblings, 1 reply; 11+ messages in thread
From: Jiri Pirko @ 2024-04-02 11:16 UTC (permalink / raw)
To: Jakub Kicinski
Cc: gaoxingwang, mkubecek, idosch, netdev, linux-kernel, yanan,
liaichun
Fri, Mar 22, 2024 at 04:07:27PM CET, kuba@kernel.org wrote:
>On Fri, 22 Mar 2024 09:14:39 +0100 Jiri Pirko wrote:
>> "gaoxingwang" certainly is not.
>
>According to what rules? Honest question, I don't know much about
>transliteration of what I guess is a Chinese name.
At least capital letter would be nice :) But "Wang" looks like a surname
and therefore a space would be appropriate too.
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()
2024-04-02 11:16 ` Jiri Pirko
@ 2024-04-02 12:16 ` gaoxingwang
2024-04-02 12:19 ` Heng Qi
0 siblings, 1 reply; 11+ messages in thread
From: gaoxingwang @ 2024-04-02 12:16 UTC (permalink / raw)
To: jiri, mkubecek
Cc: gaoxingwang1, idosch, kuba, liaichun, linux-kernel, netdev, yanan
Add missing colon in coalesce_reply_cb()
Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
---
netlink/coalesce.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/netlink/coalesce.c b/netlink/coalesce.c
index bc34d3d..bb93f9b 100644
--- a/netlink/coalesce.c
+++ b/netlink/coalesce.c
@@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
- show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
+ show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
show_cr();
--
2.27.0
^ permalink raw reply related [flat|nested] 11+ messages in thread* Re: [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb()
2024-04-02 12:16 ` [PATCH ethtool-next] netlink: fix typo in coalesce_reply_cb() gaoxingwang
@ 2024-04-02 12:19 ` Heng Qi
0 siblings, 0 replies; 11+ messages in thread
From: Heng Qi @ 2024-04-02 12:19 UTC (permalink / raw)
To: gaoxingwang
Cc: idosch, kuba, liaichun, linux-kernel, netdev, yanan, Jiri Pirko,
mkubecek
在 2024/4/2 下午8:16, gaoxingwang 写道:
> Add missing colon in coalesce_reply_cb()
>
> Fixes: ec573f209dfd (netlink: settings: add netlink support for coalesce tx aggr params)
> Signed-off-by: Gao Xingwang <gaoxingwang1@huawei.com>
> ---
> netlink/coalesce.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/netlink/coalesce.c b/netlink/coalesce.c
> index bc34d3d..bb93f9b 100644
> --- a/netlink/coalesce.c
> +++ b/netlink/coalesce.c
> @@ -93,7 +93,7 @@ int coalesce_reply_cb(const struct nlmsghdr *nlhdr, void *data)
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_BYTES]);
> show_u32("tx-aggr-max-frames", "tx-aggr-max-frames:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_MAX_FRAMES]);
> - show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs\t",
> + show_u32("tx-aggr-time-usecs", "tx-aggr-time-usecs:\t",
> tb[ETHTOOL_A_COALESCE_TX_AGGR_TIME_USECS]);
> show_cr();
>
Reviewed-by: Heng Qi <hengqi@linux.alibaba.com>
^ permalink raw reply [flat|nested] 11+ messages in thread