[PATCH net] gve: Add counter adminq_get_ptype_map_cnt to stats report

[PATCH net] gve: Add counter adminq_get_ptype_map_cnt to stats report

[John Fraker]

This counter counts the number of times get_ptype_map is executed on the
admin queue, and was previously missing from the stats report.

Fixes: c4b87ac87635 ("gve: Add support for DQO RX PTYPE map")
Signed-off-by: John Fraker <jfraker@google.com>
---
 drivers/net/ethernet/google/gve/gve_ethtool.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c
index 9aebfb843..dbe05402d 100644
--- a/drivers/net/ethernet/google/gve/gve_ethtool.c
+++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
@@ -73,7 +73,7 @@ static const char gve_gstrings_adminq_stats[][ETH_GSTRING_LEN] = {
 	"adminq_create_tx_queue_cnt", "adminq_create_rx_queue_cnt",
 	"adminq_destroy_tx_queue_cnt", "adminq_destroy_rx_queue_cnt",
 	"adminq_dcfg_device_resources_cnt", "adminq_set_driver_parameter_cnt",
-	"adminq_report_stats_cnt", "adminq_report_link_speed_cnt"
+	"adminq_report_stats_cnt", "adminq_report_link_speed_cnt", "adminq_get_ptype_map_cnt"
 };
 
 static const char gve_gstrings_priv_flags[][ETH_GSTRING_LEN] = {
@@ -428,6 +428,7 @@ gve_get_ethtool_stats(struct net_device *netdev,
 	data[i++] = priv->adminq_set_driver_parameter_cnt;
 	data[i++] = priv->adminq_report_stats_cnt;
 	data[i++] = priv->adminq_report_link_speed_cnt;
+	data[i++] = priv->adminq_get_ptype_map_cnt;
 }
 
 static void gve_get_channels(struct net_device *netdev,
-- 
2.44.0.291.gc1ea87d7ee-goog

Re: [PATCH net] gve: Add counter adminq_get_ptype_map_cnt to stats report

[Simon Horman]

On Thu, Mar 21, 2024 at 03:20:20PM -0700, John Fraker wrote:
> This counter counts the number of times get_ptype_map is executed on the
> admin queue, and was previously missing from the stats report.
> 
> Fixes: c4b87ac87635 ("gve: Add support for DQO RX PTYPE map")
> Signed-off-by: John Fraker <jfraker@google.com>

Hi John,

I'm fine with this patch but it feels more like an enhancement
for net-next than a fix for net.

If so, please drop the Fixes tag and repost next week after
net-next has reopened.

> ---
>  drivers/net/ethernet/google/gve/gve_ethtool.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c
> index 9aebfb843..dbe05402d 100644
> --- a/drivers/net/ethernet/google/gve/gve_ethtool.c
> +++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
> @@ -73,7 +73,7 @@ static const char gve_gstrings_adminq_stats[][ETH_GSTRING_LEN] = {
>  	"adminq_create_tx_queue_cnt", "adminq_create_rx_queue_cnt",
>  	"adminq_destroy_tx_queue_cnt", "adminq_destroy_rx_queue_cnt",
>  	"adminq_dcfg_device_resources_cnt", "adminq_set_driver_parameter_cnt",
> -	"adminq_report_stats_cnt", "adminq_report_link_speed_cnt"
> +	"adminq_report_stats_cnt", "adminq_report_link_speed_cnt", "adminq_get_ptype_map_cnt"

If you do repost, please consider reformatting this so the lines
remain no longer than 80 characters.

>  };
>  
>  static const char gve_gstrings_priv_flags[][ETH_GSTRING_LEN] = {
> @@ -428,6 +428,7 @@ gve_get_ethtool_stats(struct net_device *netdev,
>  	data[i++] = priv->adminq_set_driver_parameter_cnt;
>  	data[i++] = priv->adminq_report_stats_cnt;
>  	data[i++] = priv->adminq_report_link_speed_cnt;
> +	data[i++] = priv->adminq_get_ptype_map_cnt;
>  }
>  
>  static void gve_get_channels(struct net_device *netdev,
> -- 
> 2.44.0.291.gc1ea87d7ee-goog
> 
> 

Re: [PATCH net] gve: Add counter adminq_get_ptype_map_cnt to stats report

[Simon Horman]

On Fri, Mar 22, 2024 at 10:58:43AM -0700, John Fraker wrote:
> On Fri, Mar 22, 2024 at 6:09 AM Simon Horman <horms@kernel.org> wrote:
> 
> > On Thu, Mar 21, 2024 at 03:20:20PM -0700, John Fraker wrote:
> > > This counter counts the number of times get_ptype_map is executed on the
> > > admin queue, and was previously missing from the stats report.
> > >
> > > Fixes: c4b87ac87635 ("gve: Add support for DQO RX PTYPE map")
> > > Signed-off-by: John Fraker <jfraker@google.com>
> >
> > Hi John,
> >
> > I'm fine with this patch but it feels more like an enhancement
> > for net-next than a fix for net.
> >
> > If so, please drop the Fixes tag and repost next week after
> > net-next has reopened.
> >
> 
> 
> Thanks Simon, I wasn't quite sure where the line was for inclusion in net,
> I'll resubmit once the window opens.

Thanks John, I appreciate that it is subjective.

-- 
pw-bot: changes-requested