From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20B8D4501D; Fri, 22 Mar 2024 13:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711113955; cv=none; b=nG9U3WJHSBvYkPwF3fQf783YMd1PqFC73VVx2l7PCQLFBwI6bBmbAO9tPcIbaGm56FSVl9nLB98uOXlPJx5Nnb3iZyEe1DIv0GxaxwnkbOMYqW+47h/rMDiQkFgpHagthAgcgxBf5aMaGodVg33vlWrj+iMcLlmLdvn7iXPyEng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711113955; c=relaxed/simple; bh=CENpD5NgmAJhS3D1ZXkdYGmEklIoEZGQs/+tbDdphNA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cbXA6TZZRI4ysZppLSCGjsoknu8n4Cy4PHFm7hPiSZ+ZA9Emdai9Ooo4/vnREk5W5AQOTcxIfH+wkno49Zu1xc6KA8xGXdVaNPJPOtF+ap/7Am1jjNVgnf0oZAMQRDP2nU1hzzhtiIYTo0QQ+eB0zzS92m+HJ4wT9iFk06fOrcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JnrrkVnm; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JnrrkVnm" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E5D02C433F1; Fri, 22 Mar 2024 13:25:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711113954; bh=CENpD5NgmAJhS3D1ZXkdYGmEklIoEZGQs/+tbDdphNA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JnrrkVnmIrKqbKLZjGbRSzx7y3YfQyc7PgmFZWmwbjz345aiSwtKplKgRuaEnTF5u uU3T+NlHWG3MCJ5Vwaej26vx0+N6U9YtsgnG5nW3l+mtpEL7IgNFH323KXJLhZyyOV tMDyRgPVO2+qzNtj84FS5qcnKiHuk/iGk3hufWopnrK3NMjud6qZ0cWWWrQHejWZB3 JtAKPT4expA4Jvck6GCuitaHss6aJ0optS4vhUqewcBP8okggAXfJ0zb42eZvDJm6f CnDkhQo370bZnamTExR0XEYe63E0VHbf2k5iqzYWNLJS05jq4KGI/XXVIYeuaF+SOE B57PNzZdlWsQA== Date: Fri, 22 Mar 2024 13:25:49 +0000 From: Simon Horman To: Arnd Bergmann Cc: "David S. Miller" , David Ahern , Eric Dumazet , Jakub Kicinski , Paolo Abeni , YOSHIFUJI Hideaki , Ville Nuorvala , Arnd Bergmann , Kui-Feng Lee , Breno Leitao , Kunwu Chan , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6: fib: hide unused 'pn' variable Message-ID: <20240322132549.GG372561@kernel.org> References: <20240322131746.904943-1-arnd@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240322131746.904943-1-arnd@kernel.org> On Fri, Mar 22, 2024 at 02:14:10PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When CONFIG_IPV6_SUBTREES is disabled, the only user is hidden, causing > a 'make W=1' warning: > > net/ipv6/ip6_fib.c: In function 'fib6_add': > net/ipv6/ip6_fib.c:1388:32: error: variable 'pn' set but not used [-Werror=unused-but-set-variable] > > Add another #ifdef around the variable declaration, matching the other > uses in this file. > > Fixes: 66729e18df08 ("[IPV6] ROUTE: Make sure we have fn->leaf when adding a node on subtree.") > Signed-off-by: Arnd Bergmann ## Form letter - net-next-closed (text from Jakub) The merge window for v6.9 has begun and therefore net-next is closed for new drivers, features, code refactoring and optimizations. We are currently accepting bug fixes only. Please repost when net-next reopens after March 25th. RFC patches sent for review only are welcome at any time. See: https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle -- pw-bot: defer