From: Simon Horman <horms@kernel.org>
To: John Fraker <jfraker@google.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] gve: Add counter adminq_get_ptype_map_cnt to stats report
Date: Fri, 22 Mar 2024 20:04:56 +0000 [thread overview]
Message-ID: <20240322200456.GB387537@kernel.org> (raw)
In-Reply-To: <CAGH0z2E0Pw1nXueBggqdRhkdJLni+cPMA=dQg_jWQ3nmszu+Sg@mail.gmail.com>
On Fri, Mar 22, 2024 at 10:58:43AM -0700, John Fraker wrote:
> On Fri, Mar 22, 2024 at 6:09 AM Simon Horman <horms@kernel.org> wrote:
>
> > On Thu, Mar 21, 2024 at 03:20:20PM -0700, John Fraker wrote:
> > > This counter counts the number of times get_ptype_map is executed on the
> > > admin queue, and was previously missing from the stats report.
> > >
> > > Fixes: c4b87ac87635 ("gve: Add support for DQO RX PTYPE map")
> > > Signed-off-by: John Fraker <jfraker@google.com>
> >
> > Hi John,
> >
> > I'm fine with this patch but it feels more like an enhancement
> > for net-next than a fix for net.
> >
> > If so, please drop the Fixes tag and repost next week after
> > net-next has reopened.
> >
>
>
> Thanks Simon, I wasn't quite sure where the line was for inclusion in net,
> I'll resubmit once the window opens.
Thanks John, I appreciate that it is subjective.
--
pw-bot: changes-requested
prev parent reply other threads:[~2024-03-22 20:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 22:20 [PATCH net] gve: Add counter adminq_get_ptype_map_cnt to stats report John Fraker
2024-03-22 13:09 ` Simon Horman
[not found] ` <CAGH0z2E0Pw1nXueBggqdRhkdJLni+cPMA=dQg_jWQ3nmszu+Sg@mail.gmail.com>
2024-03-22 20:04 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240322200456.GB387537@kernel.org \
--to=horms@kernel.org \
--cc=jfraker@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).