From: Jakub Kicinski <kuba@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Johannes Berg <johannes.berg@intel.com>,
Brendan Higgins <brendanhiggins@google.com>,
David Gow <davidgow@google.com>, Rae Moar <rmoar@google.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org,
kunit-dev@googlegroups.com, x86@kernel.org
Subject: Re: kunit alltests runs broken in mainline
Date: Mon, 25 Mar 2024 18:52:35 -0700 [thread overview]
Message-ID: <20240325185235.2f704004@kernel.org> (raw)
In-Reply-To: <b743a5ec-3d07-4747-85e0-2fb2ef69db7c@sirena.org.uk>
On Mon, 25 Mar 2024 15:21:33 +0000 Mark Brown wrote:
> Hi,
>
> Commit 28b3df1fe6ba2cb4 ("kunit: add wireless unit tests") which I can't
> seem to find on lore breaks full kunit runs on non-UML builds and is now
> present in mainline. If I run:
>
> ./tools/testing/kunit/kunit.py run --alltests --cross_compile x86_64-linux-gnu- --arch x86_64
>
> on a clean tree then I get:
>
> [15:09:20] Configuring KUnit Kernel ...
> Generating .config ...
> Populating config with:
> $ make ARCH=x86_64 O=.kunit olddefconfig CROSS_COMPILE=x86_64-linux-gnu-
> ERROR:root:Not all Kconfig options selected in kunitconfig were in the generated .config.
> This is probably due to unsatisfied dependencies.
> Missing: CONFIG_IWLWIFI=y, CONFIG_WLAN_VENDOR_INTEL=y
>
> UML works fine, but other real architectures (eg, arm64) seem similarly
> broken. I've not looked properly yet, I'm a bit confused given that
> there's not even any dependencies for WLAN_VENDOR_INTEL and it's not
> mentoned in the defconfig.
I'm late to the party, but FWIW I had to toss this into netdev testing
tree as a local patch:
CONFIG_NETDEVICES=y
CONFIG_WLAN=y
CONFIG_DAMON_DBGFS_DEPRECATED=y
https://github.com/linux-netdev/testing/commit/9a632301bf3dbc9ba553562a0ba2657af6fa84d1
We run using:
./tools/testing/kunit/kunit.py run --alltests
it got broken after we fast-forwarded to Linus on Thu, so I assumed it
was kunit itself that changed. Not that I found the relevant commit.
The DAMON config was also breaking UML for us, BTW, and I don't see
any fix for that in Linus's tree. Strangeness.
next prev parent reply other threads:[~2024-03-26 1:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 15:21 kunit alltests runs broken in mainline Mark Brown
2024-03-25 15:29 ` Johannes Berg
2024-03-25 15:55 ` Mark Brown
2024-03-25 16:16 ` Johannes Berg
2024-03-25 16:23 ` Mark Brown
2024-03-25 16:42 ` Johannes Berg
2024-03-26 1:52 ` Jakub Kicinski [this message]
2024-03-26 7:55 ` Johannes Berg
2024-03-26 10:09 ` David Gow
2024-03-28 20:08 ` Shuah Khan
2024-03-28 22:11 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325185235.2f704004@kernel.org \
--to=kuba@kernel.org \
--cc=brendanhiggins@google.com \
--cc=broonie@kernel.org \
--cc=davidgow@google.com \
--cc=johannes.berg@intel.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rmoar@google.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).