From: Jakub Kicinski <kuba@kernel.org>
To: Raju Lakkaraju <Raju.Lakkaraju@microchip.com>
Cc: <netdev@vger.kernel.org>, <davem@davemloft.net>,
<pabeni@redhat.com>, <edumazet@google.com>,
<linux-kernel@vger.kernel.org>, <horms@kernel.org>,
<bryan.whitehead@microchip.com>, <UNGLinuxDriver@microchip.com>
Subject: Re: [PATCH net V1] net: lan743x: Add set RFE read fifo threshold for PCI1x1x chips
Date: Mon, 25 Mar 2024 19:53:30 -0700 [thread overview]
Message-ID: <20240325195330.630b7605@kernel.org> (raw)
In-Reply-To: <20240322064650.275174-1-Raju.Lakkaraju@microchip.com>
On Fri, 22 Mar 2024 12:16:50 +0530 Raju Lakkaraju wrote:
> +static int pci11x1x_set_rfe_rd_fifo_threshold(struct lan743x_adapter *adapter)
Let's make this a void function.
It only returns 0 and the caller doesn't check for errors, anyway.
> +{
> + u16 rev = adapter->csr.id_rev & ID_REV_CHIP_REV_MASK_;
> +
> + if (rev == ID_REV_CHIP_REV_PCI11X1X_B0_) {
> + u32 misc_ctl;
> +
> + misc_ctl = lan743x_csr_read(adapter, MISC_CTL_0);
> + misc_ctl &= ~MISC_CTL_0_RFE_READ_FIFO_MASK_;
> + misc_ctl |= FIELD_PREP(MISC_CTL_0_RFE_READ_FIFO_MASK_,
> + RFE_RD_FIFO_TH_3_DWORDS);
> + lan743x_csr_write(adapter, MISC_CTL_0, misc_ctl);
> + }
> +
> + return 0;
> +}
> +
> static int lan743x_hardware_init(struct lan743x_adapter *adapter,
> struct pci_dev *pdev)
> {
> @@ -3287,6 +3306,7 @@ static int lan743x_hardware_init(struct lan743x_adapter *adapter,
> pci11x1x_strap_get_status(adapter);
> spin_lock_init(&adapter->eth_syslock_spinlock);
> mutex_init(&adapter->sgmii_rw_lock);
> + pci11x1x_set_rfe_rd_fifo_threshold(adapter);
--
pw-bot: cr
prev parent reply other threads:[~2024-03-26 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-22 6:46 [PATCH net V1] net: lan743x: Add set RFE read fifo threshold for PCI1x1x chips Raju Lakkaraju
2024-03-22 12:38 ` Simon Horman
2024-03-26 2:53 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325195330.630b7605@kernel.org \
--to=kuba@kernel.org \
--cc=Raju.Lakkaraju@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).