From: Yedaya Katsman <yedaya.ka@gmail.com>
To: netdev@vger.kernel.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
Yedaya Katsman <yedaya.ka@gmail.com>
Subject: [PATCH] ip: Make errors direct to "list" instead of "show"
Date: Mon, 25 Mar 2024 22:48:37 +0200 [thread overview]
Message-ID: <20240325204837.3010-1-yedaya.ka@gmail.com> (raw)
The usage text and man pages only have "list" in them, but the errors
when using "ip ila list" and "ip addrlabel list" incorrectly direct to
running the "show" subcommand. Make them consistent by mentioning "list"
instead.
Signed-off-by: Yedaya Katsman <yedaya.ka@gmail.com>
---
ip/ipaddrlabel.c | 2 +-
ip/ipila.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ip/ipaddrlabel.c b/ip/ipaddrlabel.c
index b045827a03ea..d343993b64a9 100644
--- a/ip/ipaddrlabel.c
+++ b/ip/ipaddrlabel.c
@@ -101,7 +101,7 @@ static int ipaddrlabel_list(int argc, char **argv)
af = AF_INET6;
if (argc > 0) {
- fprintf(stderr, "\"ip addrlabel show\" does not take any arguments.\n");
+ fprintf(stderr, "\"ip addrlabel list\" does not take any arguments.\n");
return -1;
}
diff --git a/ip/ipila.c b/ip/ipila.c
index f4387e039f97..50d834f4625c 100644
--- a/ip/ipila.c
+++ b/ip/ipila.c
@@ -142,7 +142,7 @@ static int do_list(int argc, char **argv)
ILA_REQUEST(req, 1024, ILA_CMD_GET, NLM_F_REQUEST | NLM_F_DUMP);
if (argc > 0) {
- fprintf(stderr, "\"ip ila show\" does not take "
+ fprintf(stderr, "\"ip ila list\" does not take "
"any arguments.\n");
return -1;
}
--
2.34.1
next reply other threads:[~2024-03-25 20:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 20:48 Yedaya Katsman [this message]
2024-03-25 21:19 ` [PATCH] ip: Make errors direct to "list" instead of "show" Stephen Hemminger
2024-03-25 21:45 ` Yedaya
2024-03-28 2:17 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325204837.3010-1-yedaya.ka@gmail.com \
--to=yedaya.ka@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).