From: Daniel Jurgens <danielj@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <mst@redhat.com>, <jasowang@redhat.com>,
<xuanzhuo@linux.alibaba.com>, <virtualization@lists.linux.dev>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <jiri@nvidia.com>,
Daniel Jurgens <danielj@nvidia.com>
Subject: [PATCH net-next 3/4] virtio_net: Add a lock for the command VQ.
Date: Mon, 25 Mar 2024 16:49:10 -0500 [thread overview]
Message-ID: <20240325214912.323749-4-danielj@nvidia.com> (raw)
In-Reply-To: <20240325214912.323749-1-danielj@nvidia.com>
The command VQ will no longer be protected by the RTNL lock. Use a
spinlock to protect the control buffer header and the VQ.
Signed-off-by: Daniel Jurgens <danielj@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
---
drivers/net/virtio_net.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 6780479a1e6c..41f8dc16ff38 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -277,6 +277,7 @@ struct virtnet_info {
/* Has control virtqueue */
bool has_cvq;
+ spinlock_t cvq_lock;
/* Host can handle any s/g split between our header and packet data */
bool any_header_sg;
@@ -2513,6 +2514,7 @@ static bool virtnet_send_command(struct virtnet_info *vi, u8 class, u8 cmd,
/* Caller should know better */
BUG_ON(!virtio_has_feature(vi->vdev, VIRTIO_NET_F_CTRL_VQ));
+ guard(spinlock)(&vi->cvq_lock);
vi->ctrl->status = ~0;
vi->ctrl->hdr.class = class;
vi->ctrl->hdr.cmd = cmd;
@@ -4756,8 +4758,10 @@ static int virtnet_probe(struct virtio_device *vdev)
virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
vi->any_header_sg = true;
- if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ))
+ if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) {
vi->has_cvq = true;
+ spin_lock_init(&vi->cvq_lock);
+ }
if (virtio_has_feature(vdev, VIRTIO_NET_F_MTU)) {
mtu = virtio_cread16(vdev,
--
2.42.0
next prev parent reply other threads:[~2024-03-25 21:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 21:49 [PATCH net-next 0/4] Remove RTNL lock protection of CVQ Daniel Jurgens
2024-03-25 21:49 ` [PATCH net-next 1/4] virtio_net: Store RSS setting in virtnet_info Daniel Jurgens
2024-03-25 21:49 ` [PATCH net-next 2/4] virtio_net: Remove command data from control_buf Daniel Jurgens
2024-03-26 7:06 ` Heng Qi
2024-03-28 13:35 ` Simon Horman
2024-03-28 15:29 ` Michael S. Tsirkin
2024-03-25 21:49 ` Daniel Jurgens [this message]
2024-03-25 21:49 ` [PATCH net-next 4/4] virtio_net: Remove rtnl lock protection of command buffers Daniel Jurgens
2024-03-26 8:54 ` Heng Qi
2024-03-26 15:18 ` Dan Jurgens
2024-03-27 2:10 ` Heng Qi
2024-03-27 12:00 ` Heng Qi
2024-03-26 1:33 ` [PATCH net-next 0/4] Remove RTNL lock protection of CVQ Xuan Zhuo
2024-03-26 2:54 ` Heng Qi
2024-03-26 4:11 ` Dan Jurgens
2024-03-26 6:05 ` Heng Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240325214912.323749-4-danielj@nvidia.com \
--to=danielj@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux.dev \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).