netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Matthieu Baerts <matttbe@kernel.org>,
	netdev@vger.kernel.org, netdev-driver-reviewers@vger.kernel.org
Subject: Re: [TEST] VirtioFS instead of 9p
Date: Tue, 26 Mar 2024 07:20:05 -0700	[thread overview]
Message-ID: <20240326072005.1a7fa533@kernel.org> (raw)
In-Reply-To: <4c575cc7-22b8-42e0-a973-e06ccb82124b@lunn.ch>

On Tue, 26 Mar 2024 13:34:33 +0100 Andrew Lunn wrote:
> > > And the Rust that comes with it doesn't seem to be able to build it :(  
> > Did you try by installing Rust (rustc, cargo) via rustup [1]? It is even
> > possible to get the offline installer if it is easier [2]. With rustup,
> > you can easily install newer versions of the Rust toolchain.  
> 
> I guess part of the problem is that $RUST does not have a stable
> meaning yet. The rust in the kernel seems to need a different
> definition of $RUST to this package. And this machine is all about
> testing the kernel, so $RUST is set for how the kernel wants $RUST
> defined.
> 
> Maybe, eventually, rust will become stable, and you just install a
> rust compiler like you install a C compiler, and it just works for
> everything. But we are not there yet.

Somewhat related, our current build_rust test doesn't work because
I used rustup, and it works by adding stuff (paths mostly?) to bashrc.
Which does not get evaluated when we launch the script from a systemd
unit :( I couldn't find a "please run this as an interactive shell"
switch in bash, should we source ~/.bashrc in build_rust.sh for now?

  reply	other threads:[~2024-03-26 14:20 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-25 13:42 [ANN] net-next is OPEN Jakub Kicinski
2024-03-25 16:32 ` [TEST] VirtioFS instead of 9p (was: net-next is OPEN) Matthieu Baerts
2024-03-26  1:42   ` Jakub Kicinski
2024-03-26 10:27     ` [TEST] VirtioFS instead of 9p Matthieu Baerts
2024-03-26 12:34       ` Andrew Lunn
2024-03-26 14:20         ` Jakub Kicinski [this message]
2024-03-26 15:27           ` Andrew Lunn
2024-03-26 16:14           ` Edward Cree
2024-03-26 14:23       ` Jakub Kicinski
2024-03-26 17:02         ` Matthieu Baerts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240326072005.1a7fa533@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=matttbe@kernel.org \
    --cc=netdev-driver-reviewers@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).