* [PATCH] net: amd8111e: Drop unused copy of pm_cap
@ 2024-03-25 22:06 Bjorn Helgaas
2024-03-26 14:51 ` Simon Horman
2024-03-27 4:09 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2024-03-25 22:06 UTC (permalink / raw)
To: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni
Cc: netdev, linux-kernel, Bjorn Helgaas
From: Bjorn Helgaas <bhelgaas@google.com>
The copy of pdev->pm_cap in struct amd8111e_priv is never used. Drop it.
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
---
drivers/net/ethernet/amd/amd8111e.c | 1 -
drivers/net/ethernet/amd/amd8111e.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/net/ethernet/amd/amd8111e.c b/drivers/net/ethernet/amd/amd8111e.c
index ea6cfc2095e1..c1b5e9a94308 100644
--- a/drivers/net/ethernet/amd/amd8111e.c
+++ b/drivers/net/ethernet/amd/amd8111e.c
@@ -1796,7 +1796,6 @@ static int amd8111e_probe_one(struct pci_dev *pdev,
lp = netdev_priv(dev);
lp->pci_dev = pdev;
lp->amd8111e_net_dev = dev;
- lp->pm_cap = pdev->pm_cap;
spin_lock_init(&lp->lock);
diff --git a/drivers/net/ethernet/amd/amd8111e.h b/drivers/net/ethernet/amd/amd8111e.h
index 9d570adb295b..305232f5476d 100644
--- a/drivers/net/ethernet/amd/amd8111e.h
+++ b/drivers/net/ethernet/amd/amd8111e.h
@@ -764,7 +764,6 @@ struct amd8111e_priv{
u32 ext_phy_id;
struct amd8111e_link_config link_config;
- int pm_cap;
struct net_device *next;
int mii;
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: amd8111e: Drop unused copy of pm_cap
2024-03-25 22:06 [PATCH] net: amd8111e: Drop unused copy of pm_cap Bjorn Helgaas
@ 2024-03-26 14:51 ` Simon Horman
2024-03-27 4:09 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2024-03-26 14:51 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: David S . Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, linux-kernel, Bjorn Helgaas
On Mon, Mar 25, 2024 at 05:06:33PM -0500, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The copy of pdev->pm_cap in struct amd8111e_priv is never used. Drop it.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Simon Horman <horms@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: amd8111e: Drop unused copy of pm_cap
2024-03-25 22:06 [PATCH] net: amd8111e: Drop unused copy of pm_cap Bjorn Helgaas
2024-03-26 14:51 ` Simon Horman
@ 2024-03-27 4:09 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-27 4:09 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: davem, edumazet, kuba, pabeni, netdev, linux-kernel, bhelgaas
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 25 Mar 2024 17:06:33 -0500 you wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> The copy of pdev->pm_cap in struct amd8111e_priv is never used. Drop it.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/net/ethernet/amd/amd8111e.c | 1 -
> drivers/net/ethernet/amd/amd8111e.h | 1 -
> 2 files changed, 2 deletions(-)
Here is the summary with links:
- net: amd8111e: Drop unused copy of pm_cap
https://git.kernel.org/netdev/net-next/c/ee36b1e93b11
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-27 4:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-25 22:06 [PATCH] net: amd8111e: Drop unused copy of pm_cap Bjorn Helgaas
2024-03-26 14:51 ` Simon Horman
2024-03-27 4:09 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).