From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 64C2624B29 for ; Wed, 27 Mar 2024 03:40:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711510843; cv=none; b=JmzxlDEVg9f+tVEnolVbCaNTJgTxfvqYKZdmrSy38yAruk6dTwli8+ERggxWxFmqkG691GxMVuOqceHsGXQNPoQgmTIvb3EjJTuk46mG/WfIo8KKw34r3JxT6NdSKxfkMUFZKZR+gTTGN3/Fge0TJF2ESmBKwLVaR4bZ/eZ5VbU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711510843; c=relaxed/simple; bh=ag677tz4QLqSxD42xBOpg6BekMP6270mcExY3zWFfGE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=cch9Ajsea2ahNETkVsGJ1Us9jq23NG9HMZpAH3FfQjIBCiw1FbFDvWmBaSiaUo38jZV1f1lXFfoRgyvQ6/boPv5PL0b/G5awctY6hlvHKx9uwxlrXG9CR9VeOtqaWP+YUwwJK5PAOG2qVt/43jLUJMU3JMNzxeYILup88gpegY0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BY3SGoO/; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BY3SGoO/" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72984C43390; Wed, 27 Mar 2024 03:40:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711510842; bh=ag677tz4QLqSxD42xBOpg6BekMP6270mcExY3zWFfGE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=BY3SGoO/MBObcSVYZWz1HOfPKhJNIUZHYUCHtaI69AjvFobFwmr8W9ezUaq997NZi Cv8dj1P6mo7JAPlTLmIso2dfUe+2MOY7yBH0Imcp5ELb6T00MBvW7npWtyV3KCjfRA CDtyOjT8NRUAlkQKjBmrhKjsRH8rvOlbyZeUxtdr3MXg9YxvXaVD6JFZW8uKCIndLF bU+Fn+kmA9caMIGnPr49h1+Ie9xVM5OvDrAbZ3IanYEEyMvlPgfi0pQYGZzifmJGby A6PBM9cIpqD1q7vMsu/dkmgq+1mwEblwXskbxmm0AyGgSJY7r7dV26bRe8Y2vrqlf6 YXPX1H2WK61qw== Date: Tue, 26 Mar 2024 20:40:41 -0700 From: Jakub Kicinski To: Hangbin Liu Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Donald Hunter , Jiri Pirko , Jacob Keller , Stanislav Fomichev Subject: Re: [PATCH net-next 3/4] net: team: use policy generated by YAML spec Message-ID: <20240326204041.281cdd38@kernel.org> In-Reply-To: <20240326033005.2072622-4-liuhangbin@gmail.com> References: <20240326033005.2072622-1-liuhangbin@gmail.com> <20240326033005.2072622-4-liuhangbin@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 26 Mar 2024 11:30:03 +0800 Hangbin Liu wrote: > > -static int team_nl_cmd_port_list_get(struct sk_buff *skb, > +int team_nl_port_list_get_doit(struct sk_buff *skb, > struct genl_info *info) nit: please adjust the indent of the continuation line > +/* Global operation policy for team */ > +const struct nla_policy team_nl_policy[TEAM_ATTR_LIST_OPTION + 1] = { You need to adjust max_attr in the family to be ARRAY_SIZE(team_nl_policy), it's no longer TEAM_ATTR_MAX. -- pw-bot: cr