netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ivan Vecera <ivecera@redhat.com>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	mschmidt@redhat.com, aleksandr.loktionov@intel.com,
	jesse.brandeburg@intel.com, anthony.l.nguyen@intel.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Subject: [PATCH iwl-next v2 3/7] i40e: Refactor argument of i40e_detect_recover_hung()
Date: Wed, 27 Mar 2024 08:57:29 +0100	[thread overview]
Message-ID: <20240327075733.8967-4-ivecera@redhat.com> (raw)
In-Reply-To: <20240327075733.8967-1-ivecera@redhat.com>

Commit 07d44190a389 ("i40e/i40evf: Detect and recover hung queue
scenario") changes i40e_detect_recover_hung() argument type from
i40e_pf* to i40e_vsi* to be shareable by both i40e and i40evf.
Because the i40evf does not exist anymore and the function is
exclusively used by i40e we can revert this change.

Reviewed-by: Michal Schmidt <mschmidt@redhat.com>
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/net/ethernet/intel/i40e/i40e_main.c |  2 +-
 drivers/net/ethernet/intel/i40e/i40e_txrx.c | 10 ++++++----
 drivers/net/ethernet/intel/i40e/i40e_txrx.h |  2 +-
 3 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 7fed7fb69d4e..1ba28893f49e 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_main.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
@@ -11274,7 +11274,7 @@ static void i40e_service_task(struct work_struct *work)
 		return;
 
 	if (!test_bit(__I40E_RECOVERY_MODE, pf->state)) {
-		i40e_detect_recover_hung(pf->vsi[pf->lan_vsi]);
+		i40e_detect_recover_hung(pf);
 		i40e_sync_filters_subtask(pf);
 		i40e_reset_subtask(pf);
 		i40e_handle_mdd_event(pf);
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 1a12b732818e..e35a08de16b2 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -860,13 +860,15 @@ u32 i40e_get_tx_pending(struct i40e_ring *ring, bool in_sw)
 
 /**
  * i40e_detect_recover_hung - Function to detect and recover hung_queues
- * @vsi:  pointer to vsi struct with tx queues
+ * @pf: pointer to PF struct
  *
- * VSI has netdev and netdev has TX queues. This function is to check each of
- * those TX queues if they are hung, trigger recovery by issuing SW interrupt.
+ * LAN VSI has netdev and netdev has TX queues. This function is to check
+ * each of those TX queues if they are hung, trigger recovery by issuing
+ * SW interrupt.
  **/
-void i40e_detect_recover_hung(struct i40e_vsi *vsi)
+void i40e_detect_recover_hung(struct i40e_pf *pf)
 {
+	struct i40e_vsi *vsi = pf->vsi[pf->lan_vsi];
 	struct i40e_ring *tx_ring = NULL;
 	struct net_device *netdev;
 	unsigned int i;
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.h b/drivers/net/ethernet/intel/i40e/i40e_txrx.h
index 2cdc7de6301c..7c26c9a2bf65 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.h
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.h
@@ -470,7 +470,7 @@ void i40e_free_rx_resources(struct i40e_ring *rx_ring);
 int i40e_napi_poll(struct napi_struct *napi, int budget);
 void i40e_force_wb(struct i40e_vsi *vsi, struct i40e_q_vector *q_vector);
 u32 i40e_get_tx_pending(struct i40e_ring *ring, bool in_sw);
-void i40e_detect_recover_hung(struct i40e_vsi *vsi);
+void i40e_detect_recover_hung(struct i40e_pf *pf);
 int __i40e_maybe_stop_tx(struct i40e_ring *tx_ring, int size);
 bool __i40e_chk_linearize(struct sk_buff *skb);
 int i40e_xdp_xmit(struct net_device *dev, int n, struct xdp_frame **frames,
-- 
2.43.0


  parent reply	other threads:[~2024-03-27  7:57 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  7:57 [PATCH iwl-next v2 0/7] i40e: cleanups & refactors Ivan Vecera
2024-03-27  7:57 ` [PATCH iwl-next v2 1/7] i40e: Remove flags field from i40e_veb Ivan Vecera
2024-03-28 17:23   ` Simon Horman
2024-04-02  4:20   ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-03-27  7:57 ` [PATCH iwl-next v2 2/7] i40e: Refactor argument of several client notification functions Ivan Vecera
2024-03-28 17:22   ` Simon Horman
2024-03-27  7:57 ` Ivan Vecera [this message]
2024-03-28 17:23   ` [PATCH iwl-next v2 3/7] i40e: Refactor argument of i40e_detect_recover_hung() Simon Horman
2024-03-29  4:47   ` Kalesh Anakkur Purayil
2024-03-29 11:02     ` [Intel-wired-lan] " Loktionov, Aleksandr
2024-04-02  4:21   ` Pucha, HimasekharX Reddy
2024-03-27  7:57 ` [PATCH iwl-next v2 4/7] i40e: Add helper to access main VSI Ivan Vecera
2024-03-28 17:24   ` Simon Horman
2024-04-02  4:23   ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-03-27  7:57 ` [PATCH iwl-next v2 5/7] i40e: Consolidate checks whether given VSI is main Ivan Vecera
2024-03-28 17:24   ` Simon Horman
2024-04-02  4:25   ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-03-27  7:57 ` [PATCH iwl-next v2 6/7] i40e: Add helper to access main VEB Ivan Vecera
2024-03-28 17:24   ` Simon Horman
2024-04-02  4:33   ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-03-27  7:57 ` [PATCH iwl-next v2 7/7] i40e: Add and use helper to reconfigure TC for given VSI Ivan Vecera
2024-03-28 17:25   ` Simon Horman
2024-04-12 14:19   ` [Intel-wired-lan] " Pucha, HimasekharX Reddy
2024-04-12 21:19 ` [PATCH iwl-next v2 0/7] i40e: cleanups & refactors Tony Nguyen
2024-04-26 17:16   ` Ivan Vecera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240327075733.8967-4-ivecera@redhat.com \
    --to=ivecera@redhat.com \
    --cc=aleksandr.loktionov@intel.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mschmidt@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).