From: Jakub Kicinski <kuba@kernel.org>
To: Simon Horman <horms@kernel.org>
Cc: Tariq Toukan <tariqt@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
Leon Romanovsky <leonro@nvidia.com>,
Carolina Jubran <cjubran@nvidia.com>, Aya Levin <ayal@nvidia.com>
Subject: Re: [PATCH net-next 5/8] net/mlx5e: Expose the VF/SF RX drop counter on the representor
Date: Thu, 28 Mar 2024 09:21:32 -0700 [thread overview]
Message-ID: <20240328092132.47877242@kernel.org> (raw)
In-Reply-To: <20240328111831.GA403975@kernel.org>
On Thu, 28 Mar 2024 11:18:31 +0000 Simon Horman wrote:
> > The "rx_vport_out_of_buffer" equals the sum of all
> > Q counters out_of_buffer values allocated on the VF/SF.
>
> Hi Carolina and Tariq,
>
> I am wondering if any consideration was given to making this
> a generic counter. Buffer exhaustion sounds like something that
> other NICs may report too.
I think it's basically rx_missed_errors from rtnl_link_stats64.
mlx5 doesn't currently report it at all, AFAICT.
next prev parent reply other threads:[~2024-03-28 16:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 22:20 [PATCH net-next 0/8] mlx5e misc patches Tariq Toukan
2024-03-26 22:20 ` [PATCH net-next 1/8] net/mlx5e: Use ethtool_sprintf/puts() to fill priv flags strings Tariq Toukan
2024-03-28 11:19 ` Simon Horman
2024-03-26 22:20 ` [PATCH net-next 2/8] net/mlx5e: Use ethtool_sprintf/puts() to fill selftests strings Tariq Toukan
2024-03-28 11:18 ` Simon Horman
2024-03-26 22:20 ` [PATCH net-next 3/8] net/mlx5e: Use ethtool_sprintf/puts() to fill stats strings Tariq Toukan
2024-03-28 11:20 ` Simon Horman
2024-03-26 22:20 ` [PATCH net-next 4/8] net/mlx5e: Make stats group fill_stats callbacks consistent with the API Tariq Toukan
2024-03-28 11:20 ` Simon Horman
2024-03-26 22:20 ` [PATCH net-next 5/8] net/mlx5e: Expose the VF/SF RX drop counter on the representor Tariq Toukan
2024-03-28 11:18 ` Simon Horman
2024-03-28 16:21 ` Jakub Kicinski [this message]
2024-03-31 18:52 ` Tariq Toukan
2024-04-01 15:03 ` Jakub Kicinski
2024-04-02 18:02 ` Rahul Rameshbabu
2024-03-26 22:20 ` [PATCH net-next 6/8] net/mlx5e: debugfs, Add reset option for command interface stats Tariq Toukan
2024-03-28 11:20 ` Simon Horman
2024-03-26 22:20 ` [PATCH net-next 7/8] net/mlx5e: XDP, Fix an inconsistent comment Tariq Toukan
2024-03-28 11:17 ` Simon Horman
2024-03-26 22:20 ` [PATCH net-next 8/8] net/mlx5: Convert uintX_t to uX Tariq Toukan
2024-03-28 11:20 ` Simon Horman
2024-03-28 16:25 ` [PATCH net-next 0/8] mlx5e misc patches Jakub Kicinski
2024-03-28 22:28 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328092132.47877242@kernel.org \
--to=kuba@kernel.org \
--cc=ayal@nvidia.com \
--cc=cjubran@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=horms@kernel.org \
--cc=leonro@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).