Re: [PATCH bpf-next v2 6/9] bpf: tracing: add multi-link support

kernel test robot
2024-03-11T21:37:08Z

Hi Menglong,

kernel test robot noticed the following build errors:

[auto build test ERROR on bpf-next/master]

url: https://github.com/intel-lab-lkp/linux/commits/Menglong-Dong/bpf-tracing-add-support-to-record-and-check-the-accessed-args/20240311-173954
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
patch link: https://lore.kernel.org/r/20240311093526.1010158-7-dongmenglong.8%40bytedance.com
patch subject: [PATCH bpf-next v2 6/9] bpf: tracing: add multi-link support
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20240312/202403120515.LMAOyTdG-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240312/202403120515.LMAOyTdG-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403120515.LMAOyTdG-lkp@intel.com/

All errors (new ones prefixed by >>):

kernel/bpf/syscall.c: In function 'bpf_tracing_multi_link_release':
>> kernel/bpf/syscall.c:3538:9: error: implicit declaration of function 'bpf_trampoline_multi_unlink_prog'; did you mean 'bpf_trampoline_unlink_prog'? [-Werror=implicit-function-declaration]
3538 | bpf_trampoline_multi_unlink_prog(&multi_link->link);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| bpf_trampoline_unlink_prog
kernel/bpf/syscall.c: In function 'bpf_tracing_prog_attach_multi':
>> kernel/bpf/syscall.c:3815:15: error: implicit declaration of function 'bpf_trampoline_multi_link_prog'; did you mean 'bpf_trampoline_unlink_prog'? [-Werror=implicit-function-declaration]
3815 | err = bpf_trampoline_multi_link_prog(&link->link);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| bpf_trampoline_unlink_prog
cc1: some warnings being treated as errors

vim +3538 kernel/bpf/syscall.c

3532
3533 static void bpf_tracing_multi_link_release(struct bpf_link *link)
3534 {
3535 struct bpf_tracing_multi_link *multi_link =
3536 container_of(link, struct bpf_tracing_multi_link, link.link);
3537
> 3538 bpf_trampoline_multi_unlink_prog(&multi_link->link);
3539 __bpf_tracing_multi_link_release(multi_link);
3540 }
3541

--
0-DAY CI Kernel Test Service