From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: Jian Wen <wenjianhn@gmail.com>, <jiri@mellanox.com>,
<edumazet@google.com>, <davem@davemloft.net>,
"Jian Wen" <wenjian1@xiaomi.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v2] devlink: use kvzalloc() to allocate devlink instance resources
Date: Thu, 28 Mar 2024 18:49:58 -0700 [thread overview]
Message-ID: <20240328184958.3638e5a0@kernel.org> (raw)
In-Reply-To: <40b3371a-5966-4140-922e-7c62a1c73e6c@intel.com>
On Wed, 27 Mar 2024 11:15:08 +0100 Alexander Lobakin wrote:
> > Changes since v1:
> > - Use struct_size(devlink, priv, priv_size) as suggested by Alexander Lobakin
The change log should go under ---
and would be great to include a link to the previous version (from lore)
> > Signed-off-by: Jian Wen <wenjian1@xiaomi.com>
>
> Since it actually fixes a bug splat, you may want to send it with prefix
> "net" instead of "net-next" and add a "Fixes:" tag here blaming the
> first commit which added Devlink instance allocation. Let's see what
> others think.
That's my initial reaction as well. We often treat memory
pressure improvements as fixes. But thinking more we would
need to check if any of the drivers puts a DMA buffer in its priv.
Some FW mailbox, maybe? It's possible.
next prev parent reply other threads:[~2024-03-29 1:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-27 8:21 [PATCH net-next v2] devlink: use kvzalloc() to allocate devlink instance resources Jian Wen
2024-03-27 10:15 ` Alexander Lobakin
2024-03-28 1:42 ` Jian Wen
2024-03-29 1:49 ` Jakub Kicinski [this message]
2024-03-29 19:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240328184958.3638e5a0@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=wenjian1@xiaomi.com \
--cc=wenjianhn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).