netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Chintan Vankar <c-vankar@ti.com>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
	Siddharth Vadapalli <s-vadapalli@ti.com>,
	Grygorii Strashko <grygorii.strashko@ti.com>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Andrew Lunn <andrew@lunn.ch>, Roger Quadros <rogerq@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v4 2/3] net: ethernet: ti: am65-cpsw: Enable RX HW timestamp only for PTP packets
Date: Fri, 29 Mar 2024 14:59:04 -0700	[thread overview]
Message-ID: <20240329145904.0b7cb60f@kernel.org> (raw)
In-Reply-To: <20240327054234.1906957-2-c-vankar@ti.com>

On Wed, 27 Mar 2024 11:12:33 +0530 Chintan Vankar wrote:
> To prevent port lock up, disable TSTAMP_EN bit in CPTS_CONTROL
> register. The workaround for timestamping received packets is to
> utilize the CPTS Event FIFO that records timestamps corresponding to
> certain events, with one such event being the reception of an
> Ethernet packet with the EtherType field set to Precision Time
> Protocol (PTP).

You mention EtherType here but the drive retains L4 support,
which is somewhat confusing. Perhaps mention L4 / UDP ports
here, too.

  reply	other threads:[~2024-03-29 21:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-27  5:42 [PATCH net-next v4 1/3] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO Chintan Vankar
2024-03-27  5:42 ` [PATCH net-next v4 2/3] net: ethernet: ti: am65-cpsw: Enable RX HW timestamp only for PTP packets Chintan Vankar
2024-03-29 21:59   ` Jakub Kicinski [this message]
2024-04-01  9:44     ` Chintan Vankar
2024-03-27  5:42 ` [PATCH net-next v4 3/3] net: ethernet: ti: am65-cpsw-ethtool: Update rx_filters for CPSW's timestamping capability Chintan Vankar
2024-03-29 21:55   ` Jakub Kicinski
2024-03-29 21:55     ` Jakub Kicinski
2024-03-29 21:55     ` Jakub Kicinski
2024-04-01  9:46     ` Chintan Vankar
2024-03-29 22:01 ` [PATCH net-next v4 1/3] net: ethernet: ti: am65-cpts: Enable PTP RX HW timestamp using CPTS FIFO Jakub Kicinski
2024-03-29 22:01   ` Jakub Kicinski
2024-03-29 22:01   ` Jakub Kicinski
2024-04-01  9:42   ` Chintan Vankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240329145904.0b7cb60f@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=c-vankar@ti.com \
    --cc=dan.carpenter@linaro.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=grygorii.strashko@ti.com \
    --cc=hkallweit1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).