From: Pavan Chebbi <pavan.chebbi@broadcom.com>
To: michael.chan@broadcom.com
Cc: davem@davemloft.net, edumazet@google.com, gospo@broadcom.com,
kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,
Vikas Gupta <vikas.gupta@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>
Subject: [PATCH net-next 1/7] bnxt_en: Add delay to handle Downstream Port Containment (DPC) AER
Date: Sun, 31 Mar 2024 20:57:24 -0700 [thread overview]
Message-ID: <20240401035730.306790-2-pavan.chebbi@broadcom.com> (raw)
In-Reply-To: <20240401035730.306790-1-pavan.chebbi@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1241 bytes --]
From: Vikas Gupta <vikas.gupta@broadcom.com>
In case of DPC, after issuing the hot reset, the
kernel waits for 100ms for the device to complete
the reset. However on some older chips, the firmware
may take up to 1 second to complete the reset, only
after which the driver can restart the card.
Introduce delay of 900ms to handle this scenario on
the older chipsets.
Signed-off-by: Vikas Gupta <vikas.gupta@broadcom.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index b4db4b1aaffb..6e24a341ad28 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -15550,6 +15550,10 @@ static pci_ers_result_t bnxt_io_slot_reset(struct pci_dev *pdev)
netdev_info(bp->dev, "PCI Slot Reset\n");
+ if (!(bp->flags & BNXT_FLAG_CHIP_P5_PLUS) &&
+ test_bit(BNXT_STATE_PCI_CHANNEL_IO_FROZEN, &bp->state))
+ msleep(900);
+
rtnl_lock();
if (pci_enable_device(pdev)) {
--
2.39.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
next prev parent reply other threads:[~2024-04-01 3:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-01 3:57 [PATCH net-next 0/7] bnxt_en: Update for net-next Pavan Chebbi
2024-04-01 3:57 ` Pavan Chebbi [this message]
2024-04-01 3:57 ` [PATCH net-next 2/7] bnxt_en: Enable XPS by default on driver load Pavan Chebbi
2024-04-02 4:53 ` Jakub Kicinski
2024-04-01 3:57 ` [PATCH net-next 3/7] bnxt_en: Allocate page pool per numa node Pavan Chebbi
2024-04-01 3:57 ` [PATCH net-next 4/7] bnxt_en: Change bnxt_rx_xdp function prototype Pavan Chebbi
2024-04-01 3:57 ` [PATCH net-next 5/7] bnxt_en: Add XDP Metadata support Pavan Chebbi
2024-04-02 4:53 ` Jakub Kicinski
2024-04-01 3:57 ` [PATCH net-next 6/7] bnxt_en: Update firmware interface to 1.10.3.39 Pavan Chebbi
2024-04-01 3:57 ` [PATCH net-next 7/7] bnxt_en: Add warning message about disallowed speed change Pavan Chebbi
2024-04-02 4:54 ` Jakub Kicinski
2024-04-02 6:21 ` Pavan Chebbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240401035730.306790-2-pavan.chebbi@broadcom.com \
--to=pavan.chebbi@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
--cc=vikas.gupta@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).