From: Pavan Chebbi <pavan.chebbi@broadcom.com>
To: michael.chan@broadcom.com
Cc: davem@davemloft.net, edumazet@google.com, gospo@broadcom.com,
kuba@kernel.org, netdev@vger.kernel.org, pabeni@redhat.com,
Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
Kalesh AP <kalesh-anakkur.purayil@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Pavan Chebbi <pavan.chebbi@broadcom.com>
Subject: [PATCH net-next v2 7/7] bnxt_en: Add warning message about disallowed speed change
Date: Tue, 2 Apr 2024 02:37:53 -0700 [thread overview]
Message-ID: <20240402093753.331120-8-pavan.chebbi@broadcom.com> (raw)
In-Reply-To: <20240402093753.331120-1-pavan.chebbi@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1441 bytes --]
From: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Some chips may not allow changing default speed when dual rate
transceivers modules are used. Firmware on those chips will
indicate the same to the driver.
Add a warning message when speed change is not supported
because a dual rate transceiver is detected by the NIC.
Signed-off-by: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
---
v2: Fixed formatting of netdev_warn to avoid unnecessary
line break.
---
drivers/net/ethernet/broadcom/bnxt/bnxt.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
index 3982858a59a1..795f3f957eb5 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c
@@ -2525,6 +2525,9 @@ static bool bnxt_event_error_report(struct bnxt *bp, u32 data1, u32 data2)
}
return false;
}
+ case ASYNC_EVENT_CMPL_ERROR_REPORT_BASE_EVENT_DATA1_ERROR_TYPE_DUAL_DATA_RATE_NOT_SUPPORTED:
+ netdev_warn(bp->dev, "Speed change not supported with dual rate transceivers on this board\n");
+ break;
default:
netdev_err(bp->dev, "FW reported unknown error type %u\n",
err_type);
--
2.39.1
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
next prev parent reply other threads:[~2024-04-02 9:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-02 9:37 [PATCH net-next v2 0/7] bnxt_en: Update for net-next Pavan Chebbi
2024-04-02 9:37 ` [PATCH net-next v2 1/7] bnxt_en: Add delay to handle Downstream Port Containment (DPC) AER Pavan Chebbi
2024-04-02 9:37 ` [PATCH net-next v2 2/7] bnxt_en: Enable XPS by default on driver load Pavan Chebbi
2024-04-02 9:37 ` [PATCH net-next v2 3/7] bnxt_en: Allocate page pool per numa node Pavan Chebbi
2024-04-02 9:37 ` [PATCH net-next v2 4/7] bnxt_en: Change bnxt_rx_xdp function prototype Pavan Chebbi
2024-04-02 9:37 ` [PATCH net-next v2 5/7] bnxt_en: Add XDP Metadata support Pavan Chebbi
2024-04-02 9:37 ` [PATCH net-next v2 6/7] bnxt_en: Update firmware interface to 1.10.3.39 Pavan Chebbi
2024-04-02 9:37 ` Pavan Chebbi [this message]
2024-04-04 9:27 ` [PATCH net-next v2 0/7] bnxt_en: Update for net-next Paolo Abeni
2024-04-04 16:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240402093753.331120-8-pavan.chebbi@broadcom.com \
--to=pavan.chebbi@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gospo@broadcom.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
--cc=sreekanth.reddy@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).